Make the Bookmark Manager use the shared Drag And Drop library

VERIFIED FIXED

Status

SeaMonkey
Bookmarks & History
VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: Ben Goodger (use ben at mozilla dot org for email), Assigned: Ben Goodger (use ben at mozilla dot org for email))

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

patch coming soon
Created attachment 22126 [details] [diff] [review]
the new bookmarksDD.js file (for reading purposes)

Comment 3

18 years ago
need review?

Comment 4

18 years ago
|  getValueFromResource: function(aResource)
|  {
|    aResource = aResource.QueryInterface(Components.interfaces.nsIRDFResource);
|    return aResource ? aResource.Value : null;
|  },

if aResource is null, this will fail (arguably okay), but how could aResource be
null after the QI? Or do you specifically want null instead of e.g. ""?

|  getSupportedFlavours: function ()
|  {
|    var flavourSet = new FlavourSet();
|    flavourSet.appendFlavour("moz/rdfitem");
|    flavourSet.appendFlavour("text/x-moz-url");
|    flavourSet.appendFlavour("text/unicode");
|    return flavourSet;
|  },

Would it be worth caching this object?

|      if (!dropItem) {
|        dropAction = "on";
|        dropItem = containerItem.parentNode.parentNode;
|      }
|        }

A stray tab :-)

|    var containerID = containerRef || containerItem.id;
|
|    var rContainer = this.getResource(containerID);

You could merge those two for code similarity...

Just those nits, looks okay otherwise.

Updated

18 years ago
Blocks: 53403

Comment 5

18 years ago
fix checked in. (ben, not hyatt) 
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 6

17 years ago
rubber-stamping VERIFIED Fixed
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.