647362 - Use HTTP status codes for AJAX errors

Status: RESOLVED FIXED

(Websites Graveyard :: markup.mozilla.org, defect)

Description

[Fred Wenzel [:wenzel]]

markup.requests.* send JSON errors with a 200 response code and success=False or error=something in the content.

This bears the risk of an error reply being cached. 

Instead, please return HTTP error codes properly. A 200 code should not be used unless the request was successful.

Django has all response codes built-in that you should need:
http://docs.djangoproject.com/en/dev/ref/request-response/#httpresponse-subclasses

Further, jQuery has an error function for AJAX requests that catches such codes appropriately.

Comment 1

[Adam Miller]

https://github.com/mozilla/markup/commit/f73fb571feb3ec64b1601cc7115a5769f8695979

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Fred, is this easily testable via the front-end, with the Web Console open, or is it something you wouldn't mind verifying via code inspection?  Thanks!

Comment 3

[Austin King [:ozten]]

This isn't easily verifiable, but the code looks good.