Last Comment Bug 647462 - Video layer should not be ARGB by default
: Video layer should not be ARGB by default
Status: RESOLVED FIXED
: mobile, perf
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Linux
: -- normal with 1 vote (vote)
: mozilla6
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on:
Blocks: 641196
  Show dependency treegraph
 
Reported: 2011-04-02 11:11 PDT by Oleg Romashin (:romaxa)
Modified: 2011-07-14 22:15 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
-


Attachments
Video layer opaque by default (499 bytes, patch)
2011-04-02 11:11 PDT, Oleg Romashin (:romaxa)
cajbir.bugzilla: review+
Details | Diff | Review

Description Oleg Romashin (:romaxa) 2011-04-02 11:11:48 PDT
Created attachment 523796 [details] [diff] [review]
Video layer opaque by default

Siarhei has found that on 16bpp devices we do bunch of color conversion while playing video.

I found that we do BuildLayer always non-opaque (ARGB32), in Image container we create image which is 16bpp...
so result is 
1) yuv->rgb16 image
2) rgb16 image -> ARGB32 layer surface
3) ARGB32 layer -> rgb16 screen..

this is bad. IIUC we don't have transparent video, and no need to create layer surface with alpha.
Comment 1 Siarhei Siamashka 2011-04-11 11:07:48 PDT
Asking just in case. Could it possibly be that html5 might allow adding transparency to video via some fancy javascripts? I mean, is setting this layer as non opaque always safe?
Comment 2 Siarhei Siamashka 2011-04-11 11:09:40 PDT
sorry, I mean opaque
Comment 3 Oleg Romashin (:romaxa) 2011-04-11 11:42:50 PDT
In case of video clipping, that will be done on top level compositing stage. video itself does not have transparency.
Comment 4 :Ehsan Akhgari (out sick) 2011-04-12 14:55:20 PDT
http://hg.mozilla.org/projects/cedar/rev/ad9329ec0ee6
Comment 5 :Ehsan Akhgari (out sick) 2011-04-13 11:17:11 PDT
http://hg.mozilla.org/mozilla-central/rev/ad9329ec0ee6

Note You need to log in before you can comment on or make changes to this bug.