The default bug view has changed. See this FAQ.

Video layer should not be ARGB by default

RESOLVED FIXED in mozilla6

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

(Blocks: 1 bug, {mobile, perf})

Trunk
mozilla6
x86
Linux
mobile, perf
Points:
---

Firefox Tracking Flags

(fennec-)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 523796 [details] [diff] [review]
Video layer opaque by default

Siarhei has found that on 16bpp devices we do bunch of color conversion while playing video.

I found that we do BuildLayer always non-opaque (ARGB32), in Image container we create image which is 16bpp...
so result is 
1) yuv->rgb16 image
2) rgb16 image -> ARGB32 layer surface
3) ARGB32 layer -> rgb16 screen..

this is bad. IIUC we don't have transparent video, and no need to create layer surface with alpha.
Attachment #523796 - Flags: review?(tterribe)

Updated

6 years ago
Blocks: 641196
(Assignee)

Updated

6 years ago
Attachment #523796 - Flags: review?(tterribe) → review?(chris.double)
tracking-fennec: --- → ?
Keywords: mobile, perf

Updated

6 years ago
Attachment #523796 - Flags: review?(chris.double) → review+

Comment 1

6 years ago
Asking just in case. Could it possibly be that html5 might allow adding transparency to video via some fancy javascripts? I mean, is setting this layer as non opaque always safe?

Comment 2

6 years ago
sorry, I mean opaque
(Assignee)

Comment 3

6 years ago
In case of video clipping, that will be done on top level compositing stage. video itself does not have transparency.
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Assignee: nobody → romaxa
http://hg.mozilla.org/projects/cedar/rev/ad9329ec0ee6
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla6
http://hg.mozilla.org/mozilla-central/rev/ad9329ec0ee6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
tracking-fennec: ? → -
You need to log in before you can comment on or make changes to this bug.