Closed
Bug 647462
Opened 14 years ago
Closed 14 years ago
Video layer should not be ARGB by default
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla6
| Tracking | Status | |
|---|---|---|
| fennec | - | --- |
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
(Keywords: mobile, perf)
Attachments
(1 file)
|
499 bytes,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
Siarhei has found that on 16bpp devices we do bunch of color conversion while playing video.
I found that we do BuildLayer always non-opaque (ARGB32), in Image container we create image which is 16bpp...
so result is
1) yuv->rgb16 image
2) rgb16 image -> ARGB32 layer surface
3) ARGB32 layer -> rgb16 screen..
this is bad. IIUC we don't have transparent video, and no need to create layer surface with alpha.
Attachment #523796 -
Flags: review?(tterribe)
|
Assignee | |
Updated•14 years ago
|
Attachment #523796 -
Flags: review?(tterribe) → review?(chris.double)
|
||
Updated•14 years ago
|
|
||
Updated•14 years ago
|
Attachment #523796 -
Flags: review?(chris.double) → review+
|
||
Comment 1•14 years ago
|
||
Asking just in case. Could it possibly be that html5 might allow adding transparency to video via some fancy javascripts? I mean, is setting this layer as non opaque always safe?
|
|
||
Comment 2•14 years ago
|
||
sorry, I mean opaque
|
|
Assignee | |
Comment 3•14 years ago
|
||
In case of video clipping, that will be done on top level compositing stage. video itself does not have transparency.
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Updated•14 years ago
|
Assignee: nobody → romaxa
|
||
Comment 4•14 years ago
|
||
|
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
|
||
Updated•13 years ago
|
tracking-fennec: ? → -
You need to log in
before you can comment on or make changes to this bug.
Description
•