Closed Bug 647462 Opened 13 years ago Closed 13 years ago

Video layer should not be ARGB by default

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla6
Tracking Flags:
Tracking Status
fennec - ---

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

(Keywords: mobile, perf)

Attachments

(1 file)

Video layer opaque by default
499 bytes, patch
cajbir
: review+
Details | Diff | Splinter Review 
Siarhei has found that on 16bpp devices we do bunch of color conversion while playing video.

I found that we do BuildLayer always non-opaque (ARGB32), in Image container we create image which is 16bpp...
so result is 
1) yuv->rgb16 image
2) rgb16 image -> ARGB32 layer surface
3) ARGB32 layer -> rgb16 screen..

this is bad. IIUC we don't have transparent video, and no need to create layer surface with alpha.
Attachment #523796 - Flags: review?(tterribe)
Blocks: 641196
Attachment #523796 - Flags: review?(tterribe) → review?(chris.double)
tracking-fennec: --- → ?
Keywords: mobile, perf
Attachment #523796 - Flags: review?(chris.double) → review+
Asking just in case. Could it possibly be that html5 might allow adding transparency to video via some fancy javascripts? I mean, is setting this layer as non opaque always safe?
sorry, I mean opaque
In case of video clipping, that will be done on top level compositing stage. video itself does not have transparency.
Keywords: checkin-needed
Assignee: nobody → romaxa
http://hg.mozilla.org/projects/cedar/rev/ad9329ec0ee6
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla6
http://hg.mozilla.org/mozilla-central/rev/ad9329ec0ee6
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
tracking-fennec: ? → -
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: