Closed Bug 647526 Opened 11 years ago Closed 11 years ago

private-browsing events documentation incomplete

Categories

(Add-on SDK Graveyard :: Documentation, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: wbamberg)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: 

In the docs it's not clear if the start/stop events are dispatched before or after the switch has occurred. This is important e.g. to know if the tabs in the tabs module are the ones opened in normal or privatebrowsing mode.

Reproducible: Always
OS: Windows 7 → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → 1.0
Will: can you tackle this?
Sure.
Assignee: nobody → wbamberg
Status: UNCONFIRMED → NEW
Ever confirmed: true
Clarify that private-browsing's start and stop events are emitted _after_ the browser enters/exits private browsing mode.
Attachment #531208 - Flags: review?(dietrich)
Comment on attachment 531208 [details] [diff] [review]
clarify when events are emitted

r=me, thanks!
Attachment #531208 - Flags: review?(dietrich) → review+
Fixed by: https://github.com/mozilla/addon-sdk/commit/5a73e756c5c3dd8ac9609b915534c62402a31c44
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.