647552 - compiler warnings about initialized variables in GLXLibrary::EnsureInitialized

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Karl Tomlinson (:karlt)]

These variables are all set before used, and there are no conditional paths to confuse the compiler.  Why does it make sense to initialize?

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

I don't care strongly either way. As I see it, the argument for initializing is that that doesn't have any significant cost and can prevent future bugs, if this code gets re-shuffled in a way that makes the uninitialized values used.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

The reasons I want to fix this bug are that

* it doesn't hurt anything
* it makes the code ever so slightly more robust
* it removes a build warning that, even if unfounded (now), makes it harder to
  notice new build warnings, which could point at actual bugs

Comment 4

[Karl Tomlinson (:karlt)]

Please correct the commit message to say what is being fixed here.

Comment 5

[Karl Tomlinson (:karlt)]

s/fixed/worked around/

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/8b6d59ff790f