Closed Bug 647552 Opened 9 years ago Closed 9 years ago
compiler warnings about initialized variables in GLXLibrary::Ensure
No description provided.
Attachment #523867 - Flags: review?(bjacob)
Attachment #523867 - Flags: review?(bjacob) → review+
These variables are all set before used, and there are no conditional paths to confuse the compiler. Why does it make sense to initialize?
I don't care strongly either way. As I see it, the argument for initializing is that that doesn't have any significant cost and can prevent future bugs, if this code gets re-shuffled in a way that makes the uninitialized values used.
The reasons I want to fix this bug are that * it doesn't hurt anything * it makes the code ever so slightly more robust * it removes a build warning that, even if unfounded (now), makes it harder to notice new build warnings, which could point at actual bugs
Attachment #523867 - Attachment is obsolete: true
Whiteboard: [build_warning][needs review] → [build_warning]
Summary: Uninitialized variables in GLXLibrary::EnsureInitialized → compiler warnings about initialized variables in GLXLibrary::EnsureInitialized
Please correct the commit message to say what is being fixed here.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.