64760 - Keyword removal via editkeywords.cgi isn't complete.

Status: VERIFIED DUPLICATE of bug 69621

(Bugzilla :: Bugzilla-General, defect)

Description

[Jacob Steenhagen]

Problem: If a keyword is removed from a bug by editkeywords.cgi and a
non-empowered user attempts is the next person to add a comment to that bug,
they will recieve an error about only the owner or an empowered user can change
the keyword field.  This also causes the keyword change to be recorded under 
the name of the next person to modify the bug, not the person who deleted the 
keyword.

Suspected problem: I think this is caused by the fact that the deletion routine 
just plucks the information from the bug and doesn't store anything in the 
bugs_activty table.

Suspected solution: Parse through all bugs with the keyword to be deleted and 
store this in bugs_activity for this bug.  I suspect that doing this without 
calling processmail will cause this change to be grabbed and e-mailed the next 
time somebody changes this bug.

I noticed this problem while testing Gerv's patch for bug 64328.

Comment 1

[Andreas Franke (gone)]

I don't know if editkeywords.cgi was used to rename the newly introduced
"freeze" keyword to "hang", but it caused some real problems:
- (some) keyword-queries didn't work properly anymore (e.g. all-words or none)
- to fix this problem, I had to load each bug and hit commit
See bug 62893 for details.

Comment 2

[Jacob Steenhagen]

Reading through the desciprition in bug 62893, it looks like the problem was
cased by this bug.  Most likely what was done is the "freeze" keyword was
deleted (selecting "Yes" to do it even though there were bugs with the keyword)
and then "hang" was created.

Comment 3

[Jacob Steenhagen]

*** Bug 70823 has been marked as a duplicate of this bug. ***

Comment 4

[Jacob Steenhagen]

This is the same thing as bug 69621 and that one has more discusion.

*** This bug has been marked as a duplicate of 69621 ***

Comment 5

[Matthew Tuck [:CodeMachine]]

V.

Comment 6

[Dave Miller [:justdave]]

moving to Bugzilla product
reassign to default owner/qa for INVALID/WONTFIX/WORKSFORME/DUPLICATE