Local mail search should use "mailnews.view_default_charset" instead of "mailnews.send_default_charset".
I looked at the callers of nsMsgI18NGetDefaultMailCharset(). I think it was originally written for mail composing. The local search code should get "mailnews.view_default_charset" instead of calling the utility function.
Keywords: intl, nsbeta1
QA contact to ji.
QA Contact: momoi → ji
Instead of duplicating the same code, I added an argument to nsMsgI18NGetDefaultMailCharset() so that caller can specify what charset it's looking for. Who can review the attached code?
Status: NEW → ASSIGNED
BTW, changing "Edit -> Preferences -> Mail and Newsgroups -> Message Display" modifies "mailnews.view_default_charset". How does "mailnews.send_default_charset" get modified?
Edit -> Preferences -> Mail and Newsgroups -> Message Composition sets the send default charset
I think the function (the original one) is not actually needed since the caller can just call GetLocalizedUnicharPref(). Also it always duplicates the string so the caller needs to free it. I just realized that the message search code should use a folder charset instead of always stick to the view default. nsIMsgFolder has a charset which returns default view charset automatically. So please use it instead of getting the pref. Sorry, I did not realized that before, I going to change the title accordingly.
Summary: local mail search should use mail view default charset → local mail search should use mail folder charset
>nsIMsgFolder has a charset which returns default view charset automatically. If it is not explicitly set (I recently added a UI for that).
checked in. r=nhotta, a=sr=bienvenu mark as fixed.
mark as fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Verified with win32 and linux 2001-02-12-06-mtrunk builds. It is fixed. Problem about mail body search in a subfolder is described in bug 68630.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.