local mail search should use mail folder charset

VERIFIED FIXED

Status

MailNews Core
Internationalization
VERIFIED FIXED
17 years ago
10 years ago

People

(Reporter: nhottanscp, Assigned: Takayuki Tei)

Tracking

({intl})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
Local mail search should use "mailnews.view_default_charset" instead of
"mailnews.send_default_charset".
(Reporter)

Comment 1

17 years ago
I looked at the callers of nsMsgI18NGetDefaultMailCharset(). I think it was
originally written for mail composing. The local search code should get
"mailnews.view_default_charset" instead of calling the utility function.
Keywords: intl, nsbeta1

Comment 2

17 years ago
QA contact to ji.
QA Contact: momoi → ji
(Assignee)

Comment 3

17 years ago
Created attachment 22407 [details] [diff] [review]
improved version of nsMsgI18N
(Assignee)

Comment 4

17 years ago
Instead of duplicating the same code, I added an argument to 
nsMsgI18NGetDefaultMailCharset() so that caller can specify what charset it's 
looking for.

Who can review the attached code?
Blocks: 43221
Status: NEW → ASSIGNED
(Assignee)

Comment 5

17 years ago
BTW, changing "Edit -> Preferences -> Mail and Newsgroups -> Message Display"
modifies "mailnews.view_default_charset".  How does 
"mailnews.send_default_charset" get modified?

Comment 6

17 years ago
Edit -> Preferences -> Mail and Newsgroups -> Message Composition

sets the send default charset
(Reporter)

Comment 7

17 years ago
I think the function (the original one) is not actually needed since the caller
can just call GetLocalizedUnicharPref(). Also it always duplicates the string so
the caller needs to free it.
I just realized that the message search code should use a folder charset instead
of always stick to the view default. nsIMsgFolder has a charset which returns
default view charset automatically. So please use it instead of getting the pref.
Sorry, I did not realized that before, I going to change the title accordingly.



Summary: local mail search should use mail view default charset → local mail search should use mail folder charset
(Reporter)

Comment 8

17 years ago
>nsIMsgFolder has a charset which returns default view charset automatically.
If it is not explicitly set (I recently added a UI for that).

(Assignee)

Comment 9

17 years ago
Created attachment 22858 [details] [diff] [review]
new proposed patch using folder charset
(Assignee)

Comment 10

17 years ago
checked in.  r=nhotta, a=sr=bienvenu
mark as fixed.
(Assignee)

Comment 11

17 years ago
mark as fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 12

17 years ago
Verified with win32 and linux 2001-02-12-06-mtrunk builds. It is fixed.
Problem about mail body search in a subfolder is described in bug 68630.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.