64781 - local mail search should use mail folder charset

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect)

Description

[nhottanscp]

Local mail search should use "mailnews.view_default_charset" instead of
"mailnews.send_default_charset".

Comment 1

[nhottanscp]

I looked at the callers of nsMsgI18NGetDefaultMailCharset(). I think it was
originally written for mail composing. The local search code should get
"mailnews.view_default_charset" instead of calling the utility function.

Comment 2

[Katsuhiko Momoi]

QA contact to ji.

Comment 3

[Takayuki Tei]

Attachment: improved version of nsMsgI18N

Comment 4

[Takayuki Tei]

Instead of duplicating the same code, I added an argument to 
nsMsgI18NGetDefaultMailCharset() so that caller can specify what charset it's 
looking for.

Who can review the attached code?

Comment 5

[Takayuki Tei]

BTW, changing "Edit -> Preferences -> Mail and Newsgroups -> Message Display"
modifies "mailnews.view_default_charset".  How does 
"mailnews.send_default_charset" get modified?

Comment 6

[Katsuhiko Momoi]

Edit -> Preferences -> Mail and Newsgroups -> Message Composition

sets the send default charset

Comment 7

[nhottanscp]

I think the function (the original one) is not actually needed since the caller
can just call GetLocalizedUnicharPref(). Also it always duplicates the string so
the caller needs to free it.
I just realized that the message search code should use a folder charset instead
of always stick to the view default. nsIMsgFolder has a charset which returns
default view charset automatically. So please use it instead of getting the pref.
Sorry, I did not realized that before, I going to change the title accordingly.

Comment 8

[nhottanscp]

>nsIMsgFolder has a charset which returns default view charset automatically.
If it is not explicitly set (I recently added a UI for that).

Comment 9

[Takayuki Tei]

Attachment: new proposed patch using folder charset

Comment 10

[Takayuki Tei]

checked in.  r=nhotta, a=sr=bienvenu
mark as fixed.

Comment 11

[Takayuki Tei]

mark as fixed.

Comment 12

[ji]

Verified with win32 and linux 2001-02-12-06-mtrunk builds. It is fixed.
Problem about mail body search in a subfolder is described in bug 68630.