647876 - Omnibus ad-blocking bug for April/May/June/July/August 2011

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Comment 1

[[e-mail]]

Attachment: Testcase from Finn.no

Ad-blocking prevent content from showing up at the norwegian online sale site Finn.no
The attached file is a testcase from the "My findings" page, and when I check "Block web advertising" the content with picture disappear.

Hope the ad-blocking can be fine tuned to work around this. :-)

Comment 2

[philippe (part-time)]

(In reply to comment #1)

<div class="ad_image"> and <div class="ad_info">
blocked by div[class^="ad_"], /* line 647 - added in Bug 502536 */

I think you can unblock those with:
@-moz-document domain(Finn.no) {div[class^="ad_"] { display: block !important; }

Comment 3

[[e-mail]]

Thanks!
The content disappeared just a couple of weeks ago, but I guess that is due to path changes at their side.

I have added the two lines to my chrome/userContent.css (which I created), but it does not seem to make a difference. Any tricks, or should I just wait for a fix to be checked in?

Comment 4

[philippe (part-time)]

On browsershot.org

<div class="advert_list">
<ul class="left">
<li>
<a target="_blank" rel="header1" class="adbox" title="PSD to HTML" href="http://www.psd2html.com/order-now.html?b1">
<img width="125" height="125" alt="PSD to HTML" src="/static/images/creative/125x125/p2h.jpg"/>
</a>
</li>
….

and (front page only, I think) 
<a target="_blank" rel="right1" class="adbox" title="PSD to HTML" href="http://www.w3-markup.com/order?b2">
<img width="125" height="125" alt="PSD to HTML" src="/static/images/creative/125x125/w3m.gif"/>
</a>

--> div[class="advert_list"] and a[href][class="adbox"]

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://articles.sun-sentinel.com/2011-06-08/news/fl-photographers-letter-20110608_1_trespassing-signs-public-property

Tons of ads in various places, all which share

div[class="mod-adcpc]

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Someone please remind me about this bug shortly after we ship b1, so that we can get nightly baking of new rules in advance of 2.1rc.  We're too close to b1 to do anything with it now.

(In reply to comment #2)
> (In reply to comment #1)
> 
> <div class="ad_image"> and <div class="ad_info">
> blocked by div[class^="ad_"], /* line 647 - added in Bug 502536 */
> 
> I think you can unblock those with:
> @-moz-document domain(Finn.no) {div[class^="ad_"] { display: block
> !important; }

(In reply to comment #3) 
> I have added the two lines to my chrome/userContent.css (which I created),
> but it does not seem to make a difference. Any tricks, or should I just wait
> for a fix to be checked in?

Kai, philippe's rule had a small but significant typo; it needs another } at the end.  I usually write such rules over three lines to prevent myself from making that same typo, because I've done it a bunch myself:

@-moz-document domain(Finn.no) {
div[class^="ad_"] { display: block !important; }
}

I don't foresee us removing the |div[class^="ad_"]| line, so let us know if putting that rule in userContent.css or the new, designed-for-this-exact-purpose $profile/chrome/user_ad_blocking.css still doesn't work.

Comment 7

[philippe (part-time)]

Seen a few times (random !) on http://finance.yahoo.com/
(on a Flash free machine)

<a target="_blank" href="http://global.ard.yahoo.com/SIG=15l1eve25/M=806606.14807062.14561255.12376491/D=fin/S=7037371:NT1/Y=YAHOO/EXP=1312429790/L=tVy5XEPDkjnAd4ZPBrdKpQBNPXLAUk45.r4AB9gv/B=evKiEWKJiUc-/J=1312422590642763/K=bSWqhrj5kZHkk38xz4o.EA/A=6444630/R=0/*http://tr.adinterax.com/re/yahoohouse%2CSapientTest%2FYahoo_Minty_Mail%2FBundle_HighQualityVideo%2FYAHOO_BUNDLE_Expandable_Banner_954x60_collapsed_AdInterax%2CC%3DMail%2CP%3DYahoo%2CK%3D881888/0.7293019391505123/0/tc%2Cc%3Aalt_click/http://overview.mail.yahoo.com/">
<img border="0" width="954" height="60" src="http://mi.adinterax.com/customer/yahoohouse/4/SapientTest/Yahoo_Minty_Mail/Bundle/YAHOO_BUNDLE_Expandable_Banner_954x60_collapsed_AdInterax.jpg?adxq=1306932646"/>

--> a[href*="adinterax.com"] to reduce the pixel pollution

Comment 8

[philippe (part-time)]

Noticed this on
http://stiern.com/articles/usability/usability-in-icons/

Using section[id="ads"] to wrap a block around the ads [*]. The rest of the code is typical buysellads stuff, which I'm a bit wary to block on id or class with 'bsa'

<section id="ads" class="adpacks">
<div id="bsap_1260443" class="bsap_1260443 bsap">
<div class="bsa_it one">
<div id="bsa_1210907" class="bsa_it_ad ad1 odd">

[*] I would nitpick on his usage of <section> here, I'd used <aside> … Just mentioning it as we might see more alternates to <div> as a wrapper in the future.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://maps.google.com/maps/place?hl=en&safe=off&gs_upl=18373l23217l0l23573l20l11l0l0l0l0l0l0ll0l0&um=1&ie=UTF-8&q=newark+earthworks,+newark,+oh&fb=1&gl=us&hq=newark+earthworks,+newark,+oh&hnear=newark+earthworks,+newark,+oh&cid=181334633609707146

<div id="pp-ads-container"><div id="pp-text-ads-container">

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Apr/May/Jun/Jul/Aug 2011 omnibus ads

Fixes the items here (with the exception of not removing div[class^="ad_"], per comment 6) as well as the ad part of bug 654965.

Lots of months, but little more than 1 rule/month :P

Comment 11

[philippe (part-time)]

for the record, the correct url in comment 4 is browsershots.org.

Comment 12

[Stuart Morgan]

Comment on attachment 560508 [details] [diff] [review]
Apr/May/Jun/Jul/Aug 2011 omnibus ads

sr=smorgan

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/08681bc48996

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

2.0.x is gone.