Closed Bug 648066 Opened 9 years ago Closed 9 years ago

Set up aurora branch

Categories

(Release Engineering :: General, defect, P1)

x86_64
Linux
defect

Tracking

(firefox5+ fixed)

RESOLVED FIXED
Tracking Status
firefox5 + fixed

People

(Reporter: catlee, Assigned: lsblakk)

References

Details

Attachments

(10 files, 2 obsolete files)

31.06 KB, patch
catlee
: review+
lsblakk
: checked-in+
Details | Diff | Splinter Review
8.78 KB, patch
catlee
: review+
lsblakk
: checked-in+
Details | Diff | Splinter Review
10.71 KB, patch
aki
: review+
lsblakk
: checked-in+
Details | Diff | Splinter Review
825 bytes, patch
lsblakk
: review+
lsblakk
: checked-in+
Details | Diff | Splinter Review
2.46 KB, patch
bhearsum
: review+
lsblakk
: checked-in+
Details | Diff | Splinter Review
3.04 KB, patch
bhearsum
: review+
lsblakk
: checked-in+
Details | Diff | Splinter Review
849 bytes, patch
aki
: review+
Details | Diff | Splinter Review
2.39 KB, patch
lsblakk
: review+
catlee
: checked-in+
Details | Diff | Splinter Review
23.56 KB, patch
catlee
: review+
lsblakk
: checked-in+
Details | Diff | Splinter Review
1.72 KB, patch
dustin
: review+
Details | Diff | Splinter Review
We need to set up all the regular mechanics for the new aurora branch.

Assume for now that the repo will live at hg.m.o/releases/aurora.

Update snippets should be diverted into a separate directory called 'aurora-bugXXX' for now.
update channel in the mozconfigs should be 'aurora'
Depends on: 648067
Depends on: 648085
The hg repo is at hg.m.o/mozilla-aurora
Assignee: nobody → lsblakk
mozconfigs will be in a separate patch, and a graphserver bug/patch will be filed/uploaded soon.  

this is the main patch for the configs.  mozilla-aurora, not being a release branch is in project_branches and mozilla-beta as a release line is in the main configs.
Attachment #524981 - Flags: review?(catlee)
Comment on attachment 524981 [details] [diff] [review]
adds mozilla-aurora, mozlilla-beta, and three additional twigs

Looks good, except for this bit:
+        if key == 'platforms' and 'platforms' in BRANCHES[branch] and BRANCHES[branch].has_key('lock_platforms'):

I think this should be "and BRANCHES[branch].get('lock_platforms')" so that you can explicitly set lock_platforms to False if you want.
Attachment #524981 - Flags: review?(catlee) → review+
Comment on attachment 524981 [details] [diff] [review]
adds mozilla-aurora, mozlilla-beta, and three additional twigs

landed on default: http://hg.mozilla.org/build/buildbot-configs/rev/8f28e701fbce
Attachment #524981 - Flags: checked-in+
Depends on: 649054
Attached patch aurora/beta mozconfigs (obsolete) — Splinter Review
Attachment #525107 - Flags: review?(catlee)
Attachment #525107 - Flags: feedback?(bhearsum)
Comment on attachment 525107 [details] [diff] [review]
aurora/beta mozconfigs

Please use symlinks where all things are equal, eg: debug, qt configs -- except for Windows, where it's not supported.
l10n-mozconfigs will need their --with-l10n-base option updated, not sure what that is for either yet, though.
The aurora release mozconfigs aren't going to be used, so let's not even create them -- nightly needs to be on the "aurora" channel, though.

Did we decide what to do about branding?
Attachment #525107 - Flags: feedback?(bhearsum) → feedback-
> Please use symlinks where all things are equal, eg: debug, qt configs -- except
> for Windows, where it's not supported.

When I discussed this with catlee and nthomas we agreed to either do all symlink or none, and not to do mix n match -- an attempt at consistency (with forgivness for windows)

> l10n-mozconfigs will need their --with-l10n-base option updated, not sure what
> that is for either yet, though.

ok, i will check into this

> The aurora release mozconfigs aren't going to be used, so let's not even create
> them -- nightly needs to be on the "aurora" channel, though.

got it. i'll make those corrections
> 
> Did we decide what to do about branding?

do we need to file a bug to get an --enable-aurora-branding? or is there another way being discussed?
Attachment #525099 - Flags: review?(catlee) → review+
ok so apparently according to gavin, we can leave out mention of branding and the 'default' will get picked up form within the repo files to get the appropriate branding.
(In reply to comment #9)
> > Please use symlinks where all things are equal, eg: debug, qt configs -- except
> > for Windows, where it's not supported.
> 
> When I discussed this with catlee and nthomas we agreed to either do all
> symlink or none, and not to do mix n match -- an attempt at consistency (with
> forgivness for windows)

Okay, WFM!

> > Did we decide what to do about branding?
> 
> do we need to file a bug to get an --enable-aurora-branding? or is there
> another way being discussed?

We actually discussed this on IRC, it looks like you'll want:
--with-branding=browser/branding/aurora for aurora
and probably browser/branding/beta for beta

Gavin, can you confirm that?
The l10n-tree should be a mirror of l10n-central, and the l10n hg repos should be beneath http://hg.mozilla.org/l10n-aurora/, same for l10n-beta later down the line.
(In reply to comment #11)
> We actually discussed this on IRC, it looks like you'll want:
> --with-branding=browser/branding/aurora for aurora
> and probably browser/branding/beta for beta

Yeah, that flag is correct for aurora (pending the landing of the patch in bug 648368). I think beta will just want --enable-official-branding.
so i update the nightly channel for aurora - since there's no more release configs for it, the branding is not an issue actually and nor is l10n 

for beta, since it's a symlink of mozilla-central, it had the same branding settings (and l10n) as central. If that changes down the road we can replace the symlinks with hard copies
Attachment #525107 - Attachment is obsolete: true
Attachment #525107 - Flags: review?(catlee)
Attachment #525201 - Flags: review?
Attachment #525201 - Flags: review? → review?(aki)
Comment on attachment 525201 [details] [diff] [review]
aurora/beta mozconfigs

This looks right for aurora.
I'm not entirely clear on beta settings, but we have a bit more time to hash that out if it needs to change.
Attachment #525201 - Flags: review?(aki) → review+
Comment on attachment 525201 [details] [diff] [review]
aurora/beta mozconfigs

landed on default & production http://hg.mozilla.org/build/buildbot-configs/rev/50bb9e31bef2
Attachment #525201 - Flags: checked-in+
Comment on attachment 525099 [details] [diff] [review]
data.sql update for aurora, beta, additional twig branches

http://hg.mozilla.org/graphs/rev/cd860e182205
Attachment #525099 - Flags: checked-in+
Depends on: 649193
Attached patch Divert snippetsSplinter Review
Attachment #525366 - Flags: review?(lsblakk)
Attachment #525366 - Flags: review?(lsblakk) → review+
Attachment #525371 - Flags: review?(bhearsum)
Attachment #525371 - Attachment is obsolete: true
Attachment #525371 - Flags: review?(bhearsum)
Attachment #525375 - Flags: review?(bhearsum)
Comment on attachment 525375 [details] [diff] [review]
enable snippet creation for aurora

Looks good to me.
Attachment #525375 - Flags: review?(bhearsum) → review+
Comment on attachment 525397 [details] [diff] [review]
mobile needs its own download paths

The enUS_binaryURL for aurora won't work, it needs to be a full URL. Looks fine otherwise.
Attachment #525397 - Flags: review?(bhearsum) → review-
Comment on attachment 525397 [details] [diff] [review]
mobile needs its own download paths

It's a bit confusing that enUS_binaryURL has a different format in project_branches.py, but I'm not sure how else to do this, since the download_base_url differs between product and staging.
Attachment #525397 - Flags: review- → review+
(In reply to comment #25)
> Comment on attachment 525397 [details] [diff] [review]
> mobile needs its own download paths
> 
> It's a bit confusing that enUS_binaryURL has a different format in
> project_branches.py, but I'm not sure how else to do this, since the
> download_base_url differs between product and staging.

yes, we need to rely on the GLOBAL_VARS for now.  I have a bug on getting some staging stuff ironed out for project_branches so this could likely be addressed in that bug 643467
Comment on attachment 525426 [details] [diff] [review]
turn on mobile tests for aurora

Thanks Lukas!
Attachment #525426 - Flags: review?(aki) → review+
Depends on: 649468
Depends on: 649619
Attachment #525738 - Flags: review?(lsblakk)
Depends on: 649524
making this tracking-firefox5:?

649524: setup l10n repos for mozilla-aurora, mozilla-beta 

in particular this needs to be triaged and tracked daily until its complete, but since thats an IT bug it has no tracking-firefox5 flag.
Comment on attachment 525738 [details] [diff] [review]
Re-enable updates on aurora

i think your print len() statements might not want to stay in, r+ with those removed :)
Attachment #525738 - Flags: review?(lsblakk) → review+
Comment on attachment 525738 [details] [diff] [review]
Re-enable updates on aurora

Thanks, good catch!

http://hg.mozilla.org/build/buildbot-configs/rev/d2d2d6c3ef57
Attachment #525738 - Flags: checked-in+
Depends on: 649782
what the summary says: moving mozilla-aurora into config.py because it's way more than a project_branch and no longer makes sense to keep it there, adding in the l10n_repo_paths as per bug 649524, and temporarily disabling nightlies on the mozilla-beta branch to save resources until they are needed in ~5 weeks.
Attachment #525901 - Flags: review?(catlee)
Attachment #525901 - Flags: review?(catlee) → review+
Comment on attachment 525901 [details] [diff] [review]
move aurora to configs from project_branches, fix l10n repos, temp disable mozilla-beta nightlies

http://hg.mozilla.org/build/buildbot-configs/rev/6f910a2ffc4f on default
Attachment #525901 - Flags: checked-in+
Comment on attachment 526141 [details] [diff] [review]
add aurora to the gcc-4.3.3 loop in mozilla/config.py

*stamp*
Attachment #526141 - Flags: review?(dustin) → review+
No longer depends on: 649782
kicked 649782 out of the dep list and added it to blocking. this branch is setup.
Blocks: 649782
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
All setup work is done.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.