Status
()
People
(Reporter: surkov, Assigned: surkov)
Tracking
({access})
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
20.41 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
| Comment hidden (empty) |
|
(Assignee) | |
Comment 1•8 years ago
|
||
Created attachment 524382 [details] [diff] [review] patch
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #524382 -
Flags: review?(bolterbugz)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 524382 [details] [diff] [review] patch r=me. Looks good. Nit: please add back the checks for an absent READONLY state if you agree (for the cases where we don't expect READONLY of course).
Attachment #524382 -
Flags: review?(bolterbugz) → review+
|
|
(Assignee) | |
Comment 3•8 years ago
|
||
(In reply to comment #2) > Comment on attachment 524382 [details] [diff] [review] > patch > > r=me. Looks good. > > Nit: please add back the checks for an absent READONLY state if you agree (for > the cases where we don't expect READONLY of course). testStates() checks the absence of readonly state if editable state is presented and vise versa.
|
|
(Assignee) | |
Comment 4•8 years ago
|
||
btw, it was a hg copy so no existing tests are changed
|
|
(Assignee) | |
Comment 5•8 years ago
|
||
landed on cedar - http://hg.mozilla.org/projects/cedar/rev/a8449b5e6440
Whiteboard: [fixed-in-cedar]
|
||
Comment 6•8 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a8449b5e6440
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-cedar]
Target Milestone: --- → mozilla2.2
|
|
||
Comment 8•8 years ago
|
||
Ah nevermind; I see what you did.
You need to log in
before you can comment on or make changes to this bug.