Closed Bug 648235 Opened 12 years ago Closed 12 years ago

Use more underlying HTML input states for XUL textboxes

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla5

People

(Reporter: surkov, Assigned: surkov)

References

Details

(Keywords: access)

Attachments

(1 file)

patch
20.41 KB, patch
davidb
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch patch — — Splinter Review 
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED

        Attachment #524382 -
        Flags: review?(bolterbugz)

    
    

    
  
Comment on attachment 524382 [details] [diff] [review]
patch

r=me. Looks good.

Nit: please add back the checks for an absent READONLY state if you agree (for the cases where we don't expect READONLY of course).

        Attachment #524382 -
        Flags: review?(bolterbugz) → review+

    
    

    
  
(In reply to comment #2)
> Comment on attachment 524382 [details] [diff] [review]
> patch
> 
> r=me. Looks good.
> 
> Nit: please add back the checks for an absent READONLY state if you agree (for
> the cases where we don't expect READONLY of course).

testStates() checks the absence of readonly state if editable state is presented and vise versa.

    
    

    
  
btw, it was a hg copy so no existing tests are changed

    
    

    
  
landed on cedar - http://hg.mozilla.org/projects/cedar/rev/a8449b5e6440
Whiteboard: [fixed-in-cedar]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/a8449b5e6440
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-cedar]
Target Milestone: --- → mozilla2.2

    
    

    
  
Ah nevermind; I see what you did.

          You need to log in
          before you can comment on or make changes to this bug.