648235 - Use more underlying HTML input states for XUL textboxes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 524382 [details] [diff] [review]
patch

r=me. Looks good.

Nit: please add back the checks for an absent READONLY state if you agree (for the cases where we don't expect READONLY of course).

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> Comment on attachment 524382 [details] [diff] [review]
> patch
> 
> r=me. Looks good.
> 
> Nit: please add back the checks for an absent READONLY state if you agree (for
> the cases where we don't expect READONLY of course).

testStates() checks the absence of readonly state if editable state is presented and vise versa.

Comment 4

[alexander :surkov (:asurkov)]

btw, it was a hg copy so no existing tests are changed

Comment 5

[alexander :surkov (:asurkov)]

landed on cedar - http://hg.mozilla.org/projects/cedar/rev/a8449b5e6440

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/a8449b5e6440

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Re comment 3: ok :)
I don't understand comment 4.

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Ah nevermind; I see what you did.