wildcard not working for attribute axis

VERIFIED FIXED

Status

()

Core
XSLT
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: Axel Hecht, Assigned: Keith Visco)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
attribute::* doesn't match, because WildCardExpr::matches only returns
Element nodes. I will add a optional argument to matches, defaulting to
Node::ELEMENT_NODE, to match nodetype against.
I will call nodeExpr->matches(attr, context, cs, Node::ATTRIBUTE_NODE) then in
LocationStep.cpp:128.
So much, that I remember what to do tomorrow.

Axel
Axel, still working on this?
Target Milestone: --- → mozilla0.9
Blocks: 63906
(Reporter)

Comment 2

18 years ago
This one is worse than I thought it would be.
Basically because I can't just add another parameter to ::matches, it's all
over the code.
What we need to fix this is really a matter of finding the axis from within
WildcardExpr::matches. Keith, that's really above my head, please help.

Axel
(Assignee)

Comment 3

18 years ago
I'll do it this weekend. 
Status: NEW → ASSIGNED
(Assignee)

Comment 4

18 years ago
Reassinging to myself.
Assignee: axel → kvisco
Status: ASSIGNED → NEW
(Assignee)

Comment 5

18 years ago
Axel,

I just spend some time looking into this. I am just going to kill off
WildCardExpr. I am putting the proper logic in place for AttributeExpr and 
ElementExpr.

--Keith
Status: NEW → ASSIGNED
(Assignee)

Comment 6

18 years ago
I've noticed the namespace related methods for ProcessorState are being used for 
both the Result tree as well as the stylesheet tree....this is not good. I am in 
the process of trying to clean this up. I need to do this, before I can check in 
my fix for this bug, since it depends on having the proper namespace.
(Assignee)

Comment 7

18 years ago
I checked in my patches. This should now be fixed. I am awaiting verification 
from Axel. I added a quick test case in test.xsl under the axis identifiers 
section for this.

--Keith
(Reporter)

Comment 8

18 years ago
Not fixed yet, we don't get the document order right here.
How do we do document order for attributes?

This is too hefty for now, maybe later today, this week, or even this life.

Axel
(Assignee)

Comment 9

18 years ago
For attributes I use the document order for the element in which the attribute
was declared and I append a ".0"  All attributes for an element have the same 
document order.  

I still think this bug is fixed. If there is a document order problem then it's 
a different bug.

--Keith

Comment 10

17 years ago
not updates for a while on this bug. 
unsetting the target milestone.
maybe it should just be marked fixed.
Target Milestone: mozilla0.9 → ---
(Assignee)

Comment 11

17 years ago
Axel, is this still an issue?
(Reporter)

Updated

17 years ago
No longer blocks: 63906
(Reporter)

Comment 12

17 years ago
resolving. bugs have evolved alot since this one was filed.
remaining issues are in bug 92106

Axel
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 13

17 years ago
bitching buttons, verfication spam
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.