Last Comment Bug 648299 - -moz-text-decoration-style: -moz-none; does paint the decoration lines
: -moz-text-decoration-style: -moz-none; does paint the decoration lines
: dev-doc-complete
Product: Core
Classification: Components
Component: Layout: Text (show other bugs)
: Trunk
: All All
-- minor (vote)
: mozilla6
Assigned To: Masayuki Nakano [:masayuki]
Depends on:
Blocks: 59109
  Show dependency treegraph
Reported: 2011-04-07 09:47 PDT by Masayuki Nakano [:masayuki]
Modified: 2011-04-24 05:08 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1.0 (11.36 KB, patch)
2011-04-07 09:47 PDT, Masayuki Nakano [:masayuki]
dbaron: review+
Details | Diff | Splinter Review

Description User image Masayuki Nakano [:masayuki] 2011-04-07 09:47:07 PDT
Created attachment 524417 [details] [diff] [review]
Patch v1.0

I missed to implement the actual behavior of -moz-none in bug 59109. I realized this bug at working on bug 537230...
Comment 1 User image Masayuki Nakano [:masayuki] 2011-04-07 14:53:24 PDT
> dev-doc-needed

I think that we shouldn't document -moz-none for -moz-text-decoration-style. The value is used only internally, and web developers shouldn't use it. Furthermore, we're not going to propose it for web standards.
Comment 2 User image j.j. 2011-04-08 17:20:14 PDT
Documentation is also required for internal use. 
Generally everything should be documented (IMHO), where appropriate with a hint like "not intended for use in public web pages". We have such things for some other CSS properties or values.
Comment 3 User image David Baron :dbaron: ⌚️UTC-8 2011-04-22 11:56:41 PDT
Comment on attachment 524417 [details] [diff] [review]
Patch v1.0


This should either stay an assertion or that it be an if (...) { return; }.  If you don't actually hit it, leave it an assertion, otherwise make it a return without any console output.

>-  if (decorations == NS_STYLE_TEXT_DECORATION_NONE)
>+  if (decorations == NS_STYLE_TEXT_DECORATION_NONE ||
>+       strikeStyle == NS_STYLE_TEXT_DECORATION_STYLE_NONE)) {
>     return NS_OK;
>+  }

I don't think this check is worth the extra code, and it also looks like it will read uninitialized memory and therefore not actually be useful unless all three decorations are present and all set to a none style.  I'd say just leave this as it was.

r=dbaron with that
Comment 4 User image Masayuki Nakano [:masayuki] 2011-04-22 22:22:45 PDT
Comment 5 User image Florian Scholz [:fscholz] (MDN) 2011-04-24 05:08:35 PDT
Mentioned on

Note You need to log in before you can comment on or make changes to this bug.