648446 - Don't build qcms with pedantic

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

qcms is not meant to be built with pedantic so we get warning messages that are wrong.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

khuey, what's the best way to fix this?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Assuming "make it build with pedantic" is not an acceptable course of action, something like http://mxr.mozilla.org/mozilla-central/source/gfx/angle/Makefile.in#129

Comment 3

[(not currently active) Ted Mielczarek]

See also bug 394311.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Remove -pedantic from CFLAGS in qcms

Comment 5

[Jeff Muizelaar [:jrmuizel]]

http://hg.mozilla.org/mozilla-central/rev/a2884bfd1392

Comment 6

[Daniel C]

Which warnings were "wrong" out of interest?

Comment 7

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #6)
> Which warnings were "wrong" out of interest?

qcms is written in the subset of c99 that is supported by MSVC. This, for example, includes c++ style comments.