Closed Bug 648472 Opened 10 years ago Closed 10 years ago
[OS/2] avoid crashes when Fc
Font Match() fails
Code in gfxOS2Fonts.cpp seems to assume that calls to FcFontMatch() will never fail, so it never checks the returned value. Maybe it shouldn't, but I have numerous trap reports from users indicating that it does. This patch provides a workaround until the underlying cause can be determined. If FcFontMatch() fails for a given pattern, it reinvokes it asking for the default serif font (Times New Roman). In general, this "shouldn't" fail. The patch also adds checks for null pointers at appropriate points, and leaves a couple of debugging printf()'s active to help identify the problem.
In the future, please use these instructions <https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f> to generate your patches with the correct commit message and author information. Thanks!
(In reply to comment #2) > In the future, please use these instructions [...] to generate your patches > with the correct commit message and author information. Sorry. The version in my patch queue had that but I forgot to copy the info when I recreated the patch with -u8 rather the queue's -u3. The revised version has the info. carrying over r+ from wuno
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: NPOTB, OS/2 file only
Target Milestone: --- → mozilla2.2
Whiteboard: mozilla-2.0 a=NPOTB OS/2 files only
You need to log in before you can comment on or make changes to this bug.