648472 - [OS/2] avoid crashes when FcFontMatch() fails

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Rich Walsh]

Code in gfxOS2Fonts.cpp seems to assume that calls to FcFontMatch() will never fail, so it never checks the returned value.  Maybe it shouldn't, but I have numerous trap reports from users indicating that it does.

This patch provides a workaround until the underlying cause can be determined.  If FcFontMatch() fails for a given pattern, it reinvokes it asking for the default serif font (Times New Roman).  In general, this "shouldn't" fail.  The patch also adds checks for null pointers at appropriate points, and leaves a couple of debugging printf()'s active to help identify the problem.

Comment 1

[Rich Walsh]

Attachment: null font fix

Comment 2

[(no longer active)]

In the future, please use these instructions <https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f> to generate your patches with the correct commit message and author information.  Thanks!

Comment 3

[Rich Walsh]

Attachment: null font fix - v2

(In reply to comment #2)
> In the future, please use these instructions [...] to generate your patches
> with the correct commit message and author information.

Sorry.  The version in my patch queue had that but I forgot to copy the info when I recreated the patch with -u8 rather the queue's -u3.  The revised version has the info.

carrying over r+ from wuno

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/57af1004637a

Comment 5

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-2.0/rev/be7d2d8c53e3