648511 - Firefox 4.0's PDF plugin scan doesn't find full Acrobat installation

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Dave Huang]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0

Firefox is supposed to scan for Acrobat's installation directory if plugin.scan.Acrobat is set, but Firefox 4.0 doesn't find the "full" Acrobat's directory; it only finds the free Adobe Reader's install directory.

The problem seems to have been introduced in changeset 62841:04527f9407f9 for Bug 634819 - Use the nsIWindowsRegKey APIs instead of direct Win32 API calls. Prior to the change, it was looking for Acrobat's installation dir by first checking the HKLM\software\Adobe\Acrobat Reader registry key, then if that wasn't found, HKLM\software\Adobe\Adobe Acrobat. However, after the change, it first checks HKLM\software\Adobe\Acrobat Reader, then falls back to HKLM\software\Adobe\Adobe Reader.

Note the incorrect "Adobe Reader" vs. the correct "Adobe Acrobat".

Reproducible: Always

Steps to Reproduce:
1. Install Adobe Acrobat Standard (9.0 in my case). Do not install Adobe Reader
2. Install Firefox 4.0
3. Go to about:plugins
Actual Results:  
PDF plugin isn't listed in about:plugins

Expected Results:  
Expected PDF plugin to be listed in about:plugins

Comment 1

[Dave Huang]

Attachment: Correct registry path for Adobe Acrobat

Should be trivial, but here's a patch anyway :)

Comment 2

[Daniel C]

This landed as http://hg.mozilla.org/mozilla-central/rev/851fc65d2f55

Comment 3

[(no longer active)]

OMG I can't believe that I broke this.  Sorry :(

Christian, is this too late to be considered for Macaw?

Comment 4

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-2.0/rev/baa7f07fab91