Firefox 4.0's PDF plugin scan doesn't find full Acrobat installation

RESOLVED FIXED in mozilla5

Status

()

Core
Plug-ins
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Dave Huang, Assigned: Benjamin Smedberg)

Tracking

unspecified
mozilla5
x86
Windows 7
Points:
---

Firefox Tracking Flags

(blocking2.0 Macaw+, status2.0 .1-fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0

Firefox is supposed to scan for Acrobat's installation directory if plugin.scan.Acrobat is set, but Firefox 4.0 doesn't find the "full" Acrobat's directory; it only finds the free Adobe Reader's install directory.

The problem seems to have been introduced in changeset 62841:04527f9407f9 for Bug 634819 - Use the nsIWindowsRegKey APIs instead of direct Win32 API calls. Prior to the change, it was looking for Acrobat's installation dir by first checking the HKLM\software\Adobe\Acrobat Reader registry key, then if that wasn't found, HKLM\software\Adobe\Adobe Acrobat. However, after the change, it first checks HKLM\software\Adobe\Acrobat Reader, then falls back to HKLM\software\Adobe\Adobe Reader.

Note the incorrect "Adobe Reader" vs. the correct "Adobe Acrobat".

Reproducible: Always

Steps to Reproduce:
1. Install Adobe Acrobat Standard (9.0 in my case). Do not install Adobe Reader
2. Install Firefox 4.0
3. Go to about:plugins
Actual Results:  
PDF plugin isn't listed in about:plugins

Expected Results:  
Expected PDF plugin to be listed in about:plugins
(Reporter)

Comment 1

7 years ago
Created attachment 524606 [details] [diff] [review]
Correct registry path for Adobe Acrobat

Should be trivial, but here's a patch anyway :)
(Assignee)

Updated

7 years ago
Attachment #524606 - Flags: review+
(Assignee)

Updated

7 years ago
Assignee: nobody → benjamin
Blocks: 634819
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 2

7 years ago
This landed as http://hg.mozilla.org/mozilla-central/rev/851fc65d2f55
(Assignee)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
(Assignee)

Updated

7 years ago
Attachment #524606 - Flags: approval2.0?
(Assignee)

Updated

7 years ago
blocking2.0: --- → ?

Comment 3

7 years ago
OMG I can't believe that I broke this.  Sorry :(

Christian, is this too late to be considered for Macaw?

Updated

7 years ago
blocking2.0: ? → Macaw+

Updated

7 years ago
Attachment #524606 - Flags: approval2.0? → approval2.0+

Comment 4

7 years ago
http://hg.mozilla.org/releases/mozilla-2.0/rev/baa7f07fab91
status2.0: --- → .1-fixed
You need to log in before you can comment on or make changes to this bug.