648533 - URL bar is not redrawn after tap on Android search button when having Edit Bookmark popup on

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Andreea Pod]

Attachment: Overlap

Mozilla /5.0 (Android;Linux armv7l;rv:2.2a1pre) Gecko/20110407 Firefox/4.2a1pre Fennec /4.1a1pre 
Device: Samsung Captivate (Android 2.1 update 1)

Steps to reproduce:
1. Go to any website
2. Tap on the Bookmark Star > Edit
3. Click on search button of your Android system

Expected results:
Awesomebar should appear with no problem

Actual results:
The URL bar is overlapped. Please see the screenshot.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

I can reproduce this on my G2 and current trunk.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Looks like we need to close the edit bookmark dialog before displaying the awesomescreen. Can we add a check in the code used to display the awesomescreen?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 527784 [details] [diff] [review]
Patch

I can't think of any dialogs that would be open when the awesomescreen is shown that we would want to keep open. So this patch seems good to me.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mozilla-central/rev/cbe3defeccb7

Comment 6

[Anna (Waverley)]

VERIFIED FIXED on:
Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110427 Firefox/6.0a1 Fennec /6.0a1 

Devices: Samsung Galaxy Captivate(Android 2.1 update 1), HTC Desire Z (Android 2.2)