Sydney audio backend for OpenBSD's sndio

RESOLVED WONTFIX

Status

()

defect
RESOLVED WONTFIX
8 years ago
7 years ago

People

(Reporter: gaston, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments)

(Reporter)

Description

8 years ago
We're carrying a local backend for OpenBSD sndio (the equivalent to oss/alsa/pulseaudio for linux, see http://www.openbsd.org/cgi-bin/man.cgi?query=sio_open&sektion=3) since a while in OpenBSD's portstree (http://www.openbsd.org/cgi-bin/cvsweb/ports/www/mozilla-firefox/files/sydney_audio_sndio.c), so to have a little chance to see it commited upstream someday here's a tracking bug for it.

I've seen https://bugzilla.mozilla.org/show_bug.cgi?id=623444, but it could be committed to 1.9.1/1.9.2/2.0 branches in the meantime.

We also carry a modified gtk2/nsSound.cpp file to use sndio backend instead of esd/libasound, but i'm not sure nsSound.cpp is still widely used and where, cf https://bugzilla.mozilla.org/show_bug.cgi?id=520417. That could be submitted as a separate bug report, but the patch would be full of #ifdefs.

Attaching various build snippets and the backend itself, i'd appreciate feedback on the coding style since i didn't write it, nor really know how it works.
(Reporter)

Comment 1

8 years ago
Attachment #524813 - Flags: review?
(Reporter)

Comment 2

8 years ago
Attachment #524814 - Flags: review?
(Reporter)

Comment 5

8 years ago
Attachment #524818 - Flags: review?
(Reporter)

Comment 6

8 years ago
I've set review flags to ? on all files, can someone assign them to the correct person ? https://wiki.mozilla.org/Modules/All doesn't specifically list an owner for sydneyaudio, and i don't know if the Makefile.in patches requests should be assigned to a sydneyaudio owner or to each submodules owner..
Attachment #524819 - Flags: review?
Thanks for putting this patch together. We're actually in the process of replacing libsydneyaudio with our own cross platform callback-based audio library, and refactoring our <video> implementation to use that (bug 623444). We're targeting Firefox 6 with this (so it should ship to users in about 18 weeks from now if our new rapid release schedule holds). That's the same release that your patches would probably end up in. So if we took your patches to libsydneyaudio, you'd not be better off since we're about to remove libsydneyaudio anyway. I think your best approach would be to keep an eye on bug 623444 and when that lands (or even when a patch is posted there), start working on an OpenBSD backend.
(Reporter)

Comment 8

8 years ago
And in the meantime, i suppose it's to big to be commited to existing branches ?
(Reporter)

Comment 9

8 years ago
Retargetting branch 1.9.2, in the hope someone reviews it. I know it won't make it to m-c, but it could be integrated in firefox 3.5 & 3.6.
Target Milestone: --- → mozilla1.9.2
(Reporter)

Updated

8 years ago
Blocks: openbsdmeta
(Reporter)

Comment 10

8 years ago
Given the lack of move in https://bugzilla.mozilla.org/show_bug.cgi?id=623444, can this be reconsidered for inclusion in mozilla6 ?
Target Milestone: mozilla1.9.2 → mozilla6
Sorry for the delay getting back to you about this.  Bug 623444 is targeted for Firefox 6 too, so I don't think it makes sense to land this and then remove it shortly afterwards.  If that bug ends up being delayed we can definitely revisit this patch.

I'm going to post a patch to bug 623444 in the next few days that'll at least include libcubeb, the library/wrapper code replacing libsydneyaudio.  Once that's up, it'd be great if you could help out with an OpenBSD sndio backend for the new library.
Clearing target milestone, since Firefox 6 has been and gone.

The outstanding reviews on this bug are not targeted at a person, so won't appear on anyone's dashboard, not sure if you were aware?
Target Milestone: mozilla6 → ---
(Reporter)

Comment 13

7 years ago
Sorry i've been offline in the past months (accident).. as kinetik told me about 623444, i thought the patches were not aimed for landing, thus didn't set review to someone in particular. I'll try to slowly come back to all the pending stuff i had/bugs i was following, but i suppose cubeb is still the way to go, and it's not worth the effort trying to get that sydneyaudio code commited ?
Yeah I was sorry to hear about that :-( Hope things are returning to normality as fast as possible considering.
Comment on attachment 524813 [details]
Sydney audio sndio backend

Moving review to :kinetic; cpearce says he owns the sound backend and is actually in the process of replacing this library. Up to him to decide to review this, reassign this, or close as wontfix/whatever.
Attachment #524813 - Flags: review? → review?(kinetik)
Comment on attachment 524814 [details] [diff] [review]
link against sndio on OpenBSD

(I'm just going to clear the unassigned requests on these other tiny patches, probably best to roll them up into one patch file folks want to proceed with this.)
Attachment #524814 - Flags: review?
Attachment #524815 - Flags: review?
Attachment #524817 - Flags: review?
Attachment #524818 - Flags: review?
Attachment #524819 - Flags: review?
So, the work in comment 11 finally happened (mostly).  The code is landed and enabled for OS X and Windows now, with Linux coming shortly.  The best way forward is to add a backend to media/libcubeb for OpenBSD.  Landry and Alexandre discussed this with me via email last year, and there is a first pass at a cubeb backend floating around.  Let's resurrect that (in a new bug) and get it landed and enabled.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
Attachment #524813 - Flags: review?(kinetik)
You need to log in before you can comment on or make changes to this bug.