Last Comment Bug 648872 - Mismatched calling convention in worker code
: Mismatched calling convention in worker code
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla6
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
Mentors:
Depends on: 648871
Blocks: clang
  Show dependency treegraph
 
Reported: 2011-04-10 10:01 PDT by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2011-04-15 07:01 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Change the calling convention (1.00 KB, patch)
2011-04-10 10:01 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
no flags Details | Diff | Review
NS_STDCALL_FUNCPROTO (1.65 KB, patch)
2011-04-10 11:12 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
bzbarsky: review+
Details | Diff | Review
hg generated patch (1.65 KB, patch)
2011-04-14 08:06 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
no flags Details | Diff | Review
git patch with author and commit message (1.76 KB, patch)
2011-04-14 12:45 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
no flags Details | Diff | Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-04-10 10:01:45 PDT
Created attachment 524967 [details] [diff] [review]
Change the calling convention

The SetListenerFunc and EventListenerFunction types are declared with NS_STDCALL but used with NS_DEFCALL.
Comment 1 Boris Zbarsky [:bz] 2011-04-10 10:06:10 PDT
See analysis in bug 648871 comment 3.
Comment 2 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-04-10 11:12:21 PDT
Created attachment 524974 [details] [diff] [review]
NS_STDCALL_FUNCPROTO
Comment 3 Boris Zbarsky [:bz] 2011-04-12 22:31:39 PDT
Comment on attachment 524974 [details] [diff] [review]
NS_STDCALL_FUNCPROTO

r=me
Comment 4 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-04-14 08:06:12 PDT
Created attachment 526000 [details] [diff] [review]
hg generated patch
Comment 5 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-04-14 12:45:30 PDT
Created attachment 526084 [details] [diff] [review]
git patch with author and commit message
Comment 6 :Ehsan Akhgari (busy, don't ask for review please) 2011-04-14 13:00:06 PDT
http://hg.mozilla.org/projects/cedar/rev/59111031d49a
Comment 7 :Ehsan Akhgari (busy, don't ask for review please) 2011-04-15 07:01:38 PDT
http://hg.mozilla.org/mozilla-central/rev/59111031d49a

Note You need to log in before you can comment on or make changes to this bug.