649021 - Flash steals focus from inputs floated over it on double click.

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Samuel Cole]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Firefox 4.0

When you double click on an input that is positioned over a flash object (or probably any plugin), flash takes the focus on double click, instead of the normal behavior of the the input receiving focus and the text being selected.

Reproducible: Always

Steps to Reproduce:
1. Double click input positioned over flash object.
Actual Results:  
Input does not have focus, and further keystrokes result in error sounds.

Expected Results:  
Input has focus and text is selected and you may type.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Steven, this sounds like that youtube bug you were looking at....

Comment 2

[Steven Michaud [:smichaud] (Retired)]

> Steven, this sounds like that youtube bug you were looking at....

I don't know which bug you mean.

The only plugin-stealing-focus bugs I can remember, which I've worked
on recently, are bug 629593 and bug 626016 -- but these are
Windows-only and involve the QuickTime plugin.

Comment 3

[Boris Zbarsky [:bzbarsky]]

I was thinking of bug 627649.  But that was fixed in 2.0, apparently....

Comment 4

[Steven Michaud [:smichaud] (Retired)]

I can't reproduce this bug (testing with Firefox 4.0 on OS X 10.6.7).
But I'm not sure I'm doing it right.

Here's what I did:

1) Visit http://jsbin.com/udiji3 (either in the same tab or another
   tab).

2) Double-click on the text-input box labeled "over".

3) Type some letters.

   The letters I typed always appeared in the box labeled "over"
   (where they should appear).  There were no error beeps.

It made no difference whether I tested in 64-bit mode (the default) or
32-bit mode.  And in 32-bit mode it made no difference whether Flash
ran in the browser process or in a separate process.

Comment 5

[Samuel Cole]

Odd, I can still reproduce. What Flash version are you running, that might make a difference (mine is 10,2,152,26).

I've also had reports of it breaking on other machines (all OS X/Firefox).

How do I switch modes, and switch the process flash runs in? Just want to try that as well.

Comment 6

[Steven Michaud [:smichaud] (Retired)]

I tested with version 10.2.153.1, which I believe is the current
version.  Maybe that's what made the difference.

To run FF4 in 32-bit mode:

1) Right-click on the FF4 distro and choose "Get Info".

2) Check the box labeled "Open in 32-bit mode".

To run Flash in-process (only in 32-bit mode):

1) Enter about:config.

2) Change the following boolean setting from "true" (the default) to
   "false":

   dom.ipc.plugins.enabled.i386.flash player.plugin

Comment 7

[Samuel Cole]

Upgrading flash changed the behavior: I can no longer trigger the bug by double clicking on an empty field but this case is still broken:

1) Visit http://jsbin.com/udiji3 (either in the same tab or another
   tab).

2) Double-click on the text-input box labeled "over".

3) Type some letters.

2) Double-click again. Text is selected.

3) Try to type some letters.

Comment 8

[Steven Michaud [:smichaud] (Retired)]

I can now reproduce this bug (using the STR from comment #7). Thanks,
Samuel!

I see on OS X 10.6.X and 10.5.X, regardless of whether the browser is
running in 32-bit mode or 64-bit mode, and regardless of whether Flash
is running in-process or out-of-process.

Furthermore I've found this bug is a recent regression, and has this
regression range:

firefox-2011-03-01-03-mozilla-central
firefox-2011-03-02-03-mozilla-central

The only plugin-specific patch in that range is my patch for bug
627649.  So I'd bet that this bug, like bug 644110, was
caused/triggered by my patch for bug 627649.

Roc has already suggested what my turn out to be a better way to fix
bug 627649.  That might also help with this bug and with bug 644110.

Comment 9

[Steven Michaud [:smichaud] (Retired)]

This bug probably has nothing to do with Flash.  But until I can reproduce something similar using other plugins, I'll leave "Flash" in its description.

Comment 10

[Samuel Cole]

Checking in on this. It appears to still be broken as of Firefox 10.0.2.

Comment 11

[Steven Michaud [:smichaud] (Retired)]

> Roc has already suggested what my turn out to be a better way to fix
> bug 627649.

I made a stab at this a while ago at bug 658550.  But I ran into serious trouble with it, and haven't had time to go back since.

Roc's suggestion probably isn't viable as it stands.  So I'll probably need to come up with some other way to fix this bug.

Comment 12

[Samuel Cole]

I can no longer reproduce this in Firefox 15.0.1 or 16.0.1!

Curious what could have fixed it.

Comment 13

[Samuel Cole]

I just remembered I uninstalled Flash, and was in the Youtube HTML5 beta. That would do it.

I can still reproduce with Flash installed. :-(

Comment 14

[Samuel Cole]

I can still reproduce in Firefox 20.0.

Comment 15

[BMO Automation]

Resolving as wont fix, plugin support deprecated in Firefox 85.