649092 - slavealloc dbinit should be able to read from production-masters.json

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Really only useful for initial imports, but that's what dbinit does.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m649092-tools-r1.patch

This will probably break with catlee's schema changes in bug 607179, but the fix should be straightforward enough, and hopefully whoever lands last can make those fixes.

Comment 2

[Mike Taylor [:bear]]

Comment on attachment 525141 [details] [diff] [review]
m649092-tools-r1.patch

the only thing I am hesitent about is the mixing of datacentre and datacenter.  plus some whitespace issues around operators (IMO no reason to not ever use " = " except in a method signature)

so r+ if those are cleaned up

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Well, the JSON has datacentre, and the database has datacenter, and they have different values, so I don't know if there's any fixing to do there.

As for the foo=bar, my style is to use that for keyword arguments, which these are (for dict()).

Comment 4

[Mike Taylor [:bear]]

(In reply to comment #3)
> Well, the JSON has datacentre, and the database has datacenter, and they have
> different values, so I don't know if there's any fixing to do there.

k, sad but I guess no choice :)

> 
> As for the foo=bar, my style is to use that for keyword arguments, which these
> are (for dict()).

I won't push the point, just to raise the readability flag - r+ still