Closed Bug 649124 Opened 13 years ago Closed 10 years ago

Convert all existing uses of nsIDOMWindowUtils to use SpecialPowers

Categories

(Testing :: Mochitest, defect)

Product:
Testing
Component:
Mochitest
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 792083

People

(Reporter: jdm, Unassigned)

References

Details

Attachments

(1 file, 4 obsolete files)

updated patch
29.26 KB, patch
Details | Diff | Splinter Review 
From http://mxr.mozilla.org/mozilla-central/search?string=nsidomwindowutils&find=&findi=\.js&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central :

http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/WindowSnapshot.js#6
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/SimpleTest.js#318
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/EventUtils.js#212
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/EventUtils.js#272
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/EventUtils.js#400
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/EventUtils.js#611
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/EventUtils.js#670
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/EventUtils.js#681
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/test_bug366645.xhtml#25
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/ipc.js#107
http://mxr.mozilla.org/mozilla-central/source/modules/plugin/test/mochitest/test_convertpoint.xul#26
http://mxr.mozilla.org/mozilla-central/source/modules/plugin/test/mochitest/cocoa_focus.html?force=1#20
http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/tests/mochitest/chrome_wrappers_helper.html?force=1#7
http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/tests/mochitest/chrome_wrappers_helper.html?force=1#13
http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/tests/mochitest/file_doublewrappedcompartments.html?force=1#12
http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/tests/mochitest/test_frameWrapping.html?force=1#28
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/tests/test_bug525389.html?force=1#12
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/tests/test_contenteditable_text_input_handling.html?force=1#227
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/tests/test_root_element_replacement.html?force=1#100
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/file_frameElementWrapping.html?force=1#6
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/489127.html?force=1#18
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_innerScreen.xul#41
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_innerScreen.xul#65
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_domWindowUtils.html?force=1#32
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_domWindowUtils_scrollXY.html?force=1#33
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_domWindowUtils_scrollXY.html?force=1#69
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/dom-level0/innerWidthHeight_script.html?force=1#14
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/bugs/test_bug346659.html?force=1#141
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/bugs/test_bug534149.html?force=1#29
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/bugs/test_bug397571.html?force=1#27
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/bugs/test_bug581072.html?force=1#33
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/bugs/test_bug61098.html?force=1#57
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/whatwg/test_bug500328.html?force=1#153
http://mxr.mozilla.org/mozilla-central/source/dom/src/threads/test/test_closeOnGC.html?force=1#18
http://mxr.mozilla.org/mozilla-central/source/gfx/tests/mochitest/test_acceleration.html?force=1#38
http://mxr.mozilla.org/mozilla-central/source/gfx/tests/mochitest/test_bug513439.html?force=1#31
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug470212.html?force=1#25
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug391747.html?force=1#25
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug421839-1.html?force=1#49
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug421839-1.html?force=1#52
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/bug421839-2-page.html?force=1#11
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/plugin_focus_helper.html?force=1#24
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug507902.html?force=1#36
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug392746.html?force=1#26
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug392746.html?force=1#62
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug460532.html?force=1#42
http://mxr.mozilla.org/mozilla-central/source/layout/style/test/test_transitions_per_property.html?force=1#283
http://mxr.mozilla.org/mozilla-central/source/layout/style/test/test_visited_image_loading.html?force=1#38
http://mxr.mozilla.org/mozilla-central/source/layout/style/test/test_visited_image_loading_empty.html?force=1#38
http://mxr.mozilla.org/mozilla-central/source/layout/style/test/test_media_queries.html?force=1#32
http://mxr.mozilla.org/mozilla-central/source/layout/style/test/test_moz_device_pixel_ratio.html?force=1#54
http://mxr.mozilla.org/mozilla-central/source/layout/style/test/test_pointer-events.html?force=1#76
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_flush_on_paint.html?force=1#50
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug582771.html?force=1#41
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug582771.html?force=1#49
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug582771.html?force=1#57
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/bug613807-1.html?force=1#15
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug603550.html?force=1#37
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug603550.html?force=1#45
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug603550.html?force=1#53
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug603550.html?force=1#61
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug423523.html?force=1#63
http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/bug536567_subframe.html?force=1#53
http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug411236.html?force=1#48
http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug348236.html?force=1#44
http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug402198.html?force=1#58
http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug402198.html?force=1#58
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/tests/test_enchash-decrypter.xhtml#23
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/prompts/test/test_bug625187.html?force=1#34
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/prompts/test/test_bug620145.html?force=1#31
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/test/pwmgr_common.js#124
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/satchel/test/satchel_common.js#88
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/tests/widgets/test_tooltip_noautohide.xul#30
http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/test/browser/browser_615394-SSWindowState_events.js#74
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/tests/widgets/popup_shared.js#55
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/browser_gestureSupport.js#56
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/tabview/browser_tabview_bug628165.js#9
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/tabview/browser_tabview_bug626525.js#153
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/tabview/browser_tabview_snapping.js#125
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/tabview/browser_tabview_bug580412.js#88
http://mxr.mozilla.org/mozilla-central/source/docshell/test/test_bug511449.html?force=1#43
http://mxr.mozilla.org/mozilla-central/source/content/xbl/test/test_bug378518.xul#57
http://mxr.mozilla.org/mozilla-central/source/content/html/document/test/test_bug446483.html?force=1#26
http://mxr.mozilla.org/mozilla-central/source/content/html/document/test/test_viewport.html?force=1#34
http://mxr.mozilla.org/mozilla-central/source/content/html/content/test/test_bug345624-1.html?force=1#268
http://mxr.mozilla.org/mozilla-central/source/content/html/content/test/test_bug481335.xhtml#58
http://mxr.mozilla.org/mozilla-central/source/content/html/content/test/test_bug406596.html?force=1#31
http://mxr.mozilla.org/mozilla-central/source/content/html/content/test/test_bug500885.html?force=1#53
http://mxr.mozilla.org/mozilla-central/source/content/html/content/test/test_bug209275.xhtml#83
http://mxr.mozilla.org/mozilla-central/source/content/html/content/test/test_formSubmission2.html?force=1#156
http://mxr.mozilla.org/mozilla-central/source/content/html/content/test/test_bug514856.html?force=1#34
http://mxr.mozilla.org/mozilla-central/source/content/html/content/test/test_bug421640.html?force=1#27
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug574663.html?force=1#56
http://mxr.mozilla.org/mozilla-central/source/content/events/test/bug299673.js#91
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug238987.html?force=1#112
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug493251.html?force=1#37
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug493251.html?force=1#45
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug493251.html?force=1#55
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug226361.xhtml#54
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug593959.html?force=1#32
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug593959.html?force=1#43
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug605242.html?force=1#29
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug605242.html?force=1#37
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug450876.html?force=1#29
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug402089.html?force=1#58
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug508479.html?force=1#20
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug328885.html?force=1#116
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug409604.html?force=1#151
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug545268.html?force=1#40
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug545268.html?force=1#49
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug545268.html?force=1#87
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug545268.html?force=1#102
http://mxr.mozilla.org/mozilla-central/source/content/events/test/test_bug545268.html?force=1#127
http://mxr.mozilla.org/mozilla-central/source/content/xml/document/test/test_viewport.xhtml#35
http://mxr.mozilla.org/mozilla-central/source/content/svg/content/test/test_animLengthObjectIdentity.xhtml#71
http://mxr.mozilla.org/mozilla-central/source/content/xul/templates/tests/test_bug441785.xul#133
http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_bug382871.html?force=1#39
http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_websocket.html?force=1#136
http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_bug465767.html?force=1#26
http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_bug456262.html?force=1#30
http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_bug416383.html?force=1#33
http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_bug333198.html?force=1#36
http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_bug333198.html?force=1#43
http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_bug333198.html?force=1#49
http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_fileapi_slice.html?force=1#376
http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_ws_basic_tests.html?force=1#30
http://mxr.mozilla.org/mozilla-central/source/content/base/test/file_bug557892.html?force=1#18
http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_bug448993.html?force=1#26
http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_bug421602.html?force=1#30
Many of these replacements are mechanical.  This should be a very difficult bug for someone to take on, but it's one which would be really really appreciated.
Whiteboard: [mentor=jdm] [good first bug]
Doug, some of your work is certainly overlapping with the linked files up above.
And of course comment 1 should read "This _shouldn't_ be a very difficult bug".  I'm willing to help anyone who steps up willing to give it a shot.
yeah, it is overlapping.  and 'Oh man that is alot of files'...
I had started to look at this, and Joel took my patch and fiddled with it. I'm willing to drive this to completion.
Assignee: nobody → ted.mielczarek
Er, wrong bug, I meant the other one you filed. *sigh*
Assignee: ted.mielczarek → nobody
Hi Josh,
I want to take this bug. would really appreciate your help. thanks.
Great! There are a number of entries in the list in comment 0 that have existing patches that fix them, so it would be easiest right now to start with something like "all the tests under layout/ that use nsIDOMWindowUtils". Want to give that a shot? The links in the first comment that involve layout/ tests should still be unmodified, I think.
http://mxr.mozilla.org/mozilla-central/source/modules/plugin/test/mochitest/test_convertpoint.xul#26
http://mxr.mozilla.org/mozilla-central/source/modules/plugin/test/mochitest/cocoa_focus.html?force=1#20
http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/tests/mochitest/test_frameWrapping.html?force=1#28
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/tests/test_bug525389.html?force=1#12
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/tests/test_contenteditable_text_input_handling.html?force=1#227
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/tests/test_root_element_replacement.html?force=1#100
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/file_frameElementWrapping.html?force=1#6
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/489127.html?force=1#18
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_innerScreen.xul#41
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_innerScreen.xul#65
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_domWindowUtils.html?force=1#32
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_domWindowUtils_scrollXY.html?force=1#33
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/general/test_domWindowUtils_scrollXY.html?force=1#69
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/dom-level0/innerWidthHeight_script.html?force=1#14
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/bugs/test_bug346659.html?force=1#141
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/bugs/test_bug534149.html?force=1#29
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/bugs/test_bug397571.html?force=1#27
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/bugs/test_bug581072.html?force=1#33
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/bugs/test_bug61098.html?force=1#57
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/whatwg/test_bug500328.html?force=1#153
http://mxr.mozilla.org/mozilla-central/source/gfx/tests/mochitest/test_acceleration.html?force=1#38
http://mxr.mozilla.org/mozilla-central/source/gfx/tests/mochitest/test_bug513439.html?force=1#31
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug470212.html?force=1#25
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug391747.html?force=1#25
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug421839-1.html?force=1#49
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug421839-1.html?force=1#52
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/bug421839-2-page.html?force=1#11
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/plugin_focus_helper.html?force=1#24
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug507902.html?force=1#36
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug392746.html?force=1#26
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug392746.html?force=1#62
http://mxr.mozilla.org/mozilla-central/source/layout/generic/test/test_bug460532.html?force=1#42
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_flush_on_paint.html?force=1#50
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug582771.html?force=1#41
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug582771.html?force=1#49
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug582771.html?force=1#57
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/bug613807-1.html?force=1#15
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug603550.html?force=1#37
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug603550.html?force=1#45
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug603550.html?force=1#53
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug603550.html?force=1#61
http://mxr.mozilla.org/mozilla-central/source/layout/base/tests/test_bug423523.html?force=1#63
http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/bug536567_subframe.html?force=1#53
http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug411236.html?force=1#48
http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug348236.html?force=1#44
http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug402198.html?force=1#58
http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug402198.html?force=1#58
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/tests/test_enchash-decrypter.xhtml#23
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/prompts/test/test_bug625187.html?force=1#34
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/prompts/test/test_bug620145.html?force=1#31
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/test/pwmgr_common.js#124
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/satchel/test/satchel_common.js#88
http://mxr.mozilla.org/mozilla-central/source/docshell/test/test_bug511449.html?force=1#43

Here's a reduced list that *should* only contain files that need modification. If the filename has something like _common.js, that means it's a helper and not a test you can run directly. In that case you'll want to run all the tests in the directory (just take off the test filename from the TEST_PATH variable, ie. layout/style/test/)
Attached patch the patch file (obsolete) — — Splinter Review 
Hi Josh,
here is the patch file. request you please review it.

thanks,
Rahul
Comment on attachment 554846 [details] [diff] [review]
the patch file

-  var utils = win.QueryInterface(Components.interfaces.nsIInterfaceRequestor).
-                  getInterface(Components.interfaces.nsIDOMWindowUtils);
+  var utils = SpecialPowers;

this should be:
var utils = SpecialPowers.DOMWindowUtils;


Maybe I am missing something?
Assignee: nobody → me.parashar
My mistake, I had a typo when discussing the changes Rahul needed to make. Rahul, this should be easy to fix if you take the patch file and globally replace "= SpecialPowers" with "= SpecialPowers.DOMWindowUtils".
Attached patch updated patch (obsolete) — — Splinter Review 
thanks for the suggestion Josh.. i've updated the file with the changes.
Attachment #554846 - Attachment is obsolete: true
Comment on attachment 554880 [details] [diff] [review]
updated patch

one nit I would add here is to remove the enablePrivilege call if possible:

   function gc() {
     netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
-    window.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
-          .getInterface(Components.interfaces.nsIDOMWindowUtils)
-          .garbageCollect();
+    SpecialPowers.DOMWindowUtils.garbageCollect();
   }


should be:

   function gc() {
-    netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
-    window.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
-          .getInterface(Components.interfaces.nsIDOMWindowUtils)
-          .garbageCollect();
+    SpecialPowers.DOMWindowUtils.garbageCollect();
   }

in some cases this would cause failures in the test if other parts of the test depend on enablePrivilege.  I would bet we could remove at least half of the calls in these files by replacing domwindowutils.
Comment on attachment 554880 [details] [diff] [review]
updated patch

This is really close, there are just a couple more changes required. Revert whatever you did to aboutDialog.css, please, that looks unintentional.

Looks like the following tests are actually mochitest-chrome tests, so they should be reverted:
* dom/tests/mochitest/general/test_innerScreen.xul
* js/src/xpconnect/tests/mochitest/chrome_wrappers_helper.html

Otherwise this looks good! Once you make those changes, I'll push this to the try server to make sure all the tests pass.
Attached patch updated patch (obsolete) — — Splinter Review 
please try this one. although; i'm not sure about this one either because i've exported correctly but have removed the sections manually (aboutDialog.css, chrome_wrappers_helper.html etc.) please let me know if it works.
Attachment #554880 - Attachment is obsolete: true
I think your manual deletions are messing it up somehow, because I can't apply the patch at all:

godot:mozilla-central jdm$ hg qpus
applying 649124
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 649124
then how do i take 3 original files from repository? so that i can replace them in my source and export again.
sorry if i was not clear in my last msg. the files i meant are:
aboutDialog.css
chrome_wrappers_helper.html
test_innerscreen.xul
Attached patch updated patch (obsolete) — — Splinter Review 

        Attachment #555025 -
        Attachment is obsolete: true

    
    

    
  
Try run for e5da7bf8c815 is complete.
Detailed breakdown of the results available here:
    http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=e5da7bf8c815
Results (out of 97 total builds):
    success: 35
    warnings: 61
    failure: 1
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/josh@joshmatthews.net-e5da7bf8c815

    
    

    
  
Rahul, the try results show that there are a few problems with the patch. http://tbpl.allizom.org/?tree=Try&usebuildbot=1&pusher=josh@joshmatthews.net&rev=e5da7bf8c815 shows the results of all the tests; any orange number is clickable and brings up a box with a list of test failures, with each number representing part of the mochitest suite. Looks like a number of SpecialPowers -> SpecialPowers.DOMWindowUtils changes were missed.

    
    

    
  
And if fetching a log fails for any reason, you can click the "view brief log" link in the bottom left corner of the screen and you'll see the same data.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        updated patch
        — 
          — Splinter Review
      

    


  
yes, the change was missing in actually all of them, after i created the updated patch (and as SpecialPowers -> SpecialPowers.DOMWindowUtils change was a manual update), i forgot to make the change. i'm sorry to waste so much of your time in testing. here is updated patch. hope it works (as it's again a manual update)

        Attachment #555040 -
        Attachment is obsolete: true

    
    

    
  
Try run for 948dea6f2723 is complete.
Detailed breakdown of the results available here:
    http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=948dea6f2723
Results (out of 97 total builds):
    exception: 1
    success: 43
    warnings: 52
    failure: 1
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/josh@joshmatthews.net-948dea6f2723

    
    

    
  
There are errors that require further investigation here, but at least some of them will be resolved by bug 681392.

    
    

    
  
The changes to dom/tests/mochitest/bugs/test_bug61098.html should also be reverted. That test is wacky enough that we'll need to make a lot of other changes to it to make it work properly.

    
    

    
  
Try run for 6652b5890818 is complete.
Detailed breakdown of the results available here:
    http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=6652b5890818
Results (out of 97 total builds):
    exception: 2
    success: 46
    warnings: 49
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/josh@joshmatthews.net-6652b5890818

    
  
Whiteboard: [mentor=jdm] [good first bug] → [mentor=jdm] [good first bug] [lang=js]

    
    

    
  
This got bogged down a long time ago, and I think the best way to go about it now is with the script proposed in bug 792083. I'm taking it off of the mentored bugs list.
Assignee: me.parashar → nobody
Whiteboard: [mentor=jdm] [good first bug] [lang=js]

    
    

    
  
Josh, should this bug be a dupe of Bug 792083, then?
Flags: needinfo?(josh)

    
  
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(josh)
Resolution: --- → DUPLICATE

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: