649163 - nsDOMCSSDeclaration::GetCSSParsingEnvironment should not AddRef its output

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Filed per request in bug 435442 comment 37:

nsDOMCSSDeclaration::GetCSSParsingEnvironment (a pure virtual function) and its implementations currently AddRef all the out-parameters.  However, this is probably unnecessary, and it should be changed to fill in weak pointers.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop refcounting the return values from GetCSSParsingEnvironment, where possible.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 528613 [details] [diff] [review]
Stop refcounting the return values from GetCSSParsingEnvironment, where possible.

>@@ -120,17 +120,17 @@ nsDOMCSSAttributeDeclaration::DocToUpdat
>...
>   // We need GetOwnerDoc() rather than GetCurrentDoc() because it might
>   // be the BeginUpdate call that inserts mElement into the document.
>-  return mElement->GetOwnerDoc();
>+  return mElement->GetCurrentDoc();
> }

Were you just experimenting with something here?  I'm guessing this
wasn't intended to be part of the patch.  If it was, please explain.

r=dbaron assuming that wasn't supposed to be here

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Were you just experimenting with something here?

Yes.  I was sure I'd reverted that change, but clearly not.  Thank you for catching it!

Reverted locally.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: With that change reverted

Comment 5

[Boris Zbarsky [:bzbarsky]]

This was pushed as http://hg.mozilla.org/mozilla-central/rev/27987cc4f4bb