Abort when the cache IO thread can't be created

RESOLVED FIXED in mozilla14

Status

()

Core
Networking: Cache
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: michal, Assigned: michal)

Tracking

unspecified
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Right now we don't fail to initialize the cache service when initialization of a cache IO thread fails (http://hg.mozilla.org/mozilla-central/annotate/94874a2f3bb3/netwerk/cache/nsCacheService.cpp#l1031). But we do try to dispatch events to this thread with no fallback in case the thread is not available. E.g. http://hg.mozilla.org/mozilla-central/annotate/94874a2f3bb3/netwerk/cache/nsCacheService.cpp#l732

I can't see a reason why creating a new thread should fail unless the process is experiencing some fatal problem, so IMO it makes sense to fail to initialize the cache service.

Comment 1

6 years ago
I believe we should just NS_RUNTIMEABORT...
> I believe we should just NS_RUNTIMEABORT...

+1
(Assignee)

Comment 3

6 years ago
Created attachment 609517 [details] [diff] [review]
fix
Attachment #609517 - Flags: review?(bsmith)
(Assignee)

Updated

6 years ago
Summary: Handle correctly case when the cache IO thread can't be created → Abort when the cache IO thread can't be created
Comment on attachment 609517 [details] [diff] [review]
fix

Review of attachment 609517 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #609517 - Flags: review?(bsmith) → review+
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/c5d6aa6be62c

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/c5d6aa6be62c
Target Milestone: --- → mozilla14

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.