Last Comment Bug 649194 - Abort when the cache IO thread can't be created
: Abort when the cache IO thread can't be created
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: Cache (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla14
Assigned To: Michal Novotny (:michal)
:
: Patrick McManus [:mcmanus]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-11 17:21 PDT by Michal Novotny (:michal)
Modified: 2012-03-28 14:26 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (773 bytes, patch)
2012-03-26 15:52 PDT, Michal Novotny (:michal)
brian: review+
Details | Diff | Splinter Review

Description Michal Novotny (:michal) 2011-04-11 17:21:39 PDT
Right now we don't fail to initialize the cache service when initialization of a cache IO thread fails (http://hg.mozilla.org/mozilla-central/annotate/94874a2f3bb3/netwerk/cache/nsCacheService.cpp#l1031). But we do try to dispatch events to this thread with no fallback in case the thread is not available. E.g. http://hg.mozilla.org/mozilla-central/annotate/94874a2f3bb3/netwerk/cache/nsCacheService.cpp#l732

I can't see a reason why creating a new thread should fail unless the process is experiencing some fatal problem, so IMO it makes sense to fail to initialize the cache service.
Comment 1 Benjamin Smedberg [:bsmedberg] 2011-04-11 17:44:23 PDT
I believe we should just NS_RUNTIMEABORT...
Comment 2 Jason Duell [:jduell] (needinfo me) 2011-04-14 15:17:42 PDT
> I believe we should just NS_RUNTIMEABORT...

+1
Comment 3 Michal Novotny (:michal) 2012-03-26 15:52:03 PDT
Created attachment 609517 [details] [diff] [review]
fix
Comment 4 Brian Smith (:briansmith, :bsmith, use NEEDINFO?) 2012-03-26 16:25:07 PDT
Comment on attachment 609517 [details] [diff] [review]
fix

Review of attachment 609517 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Comment 5 Michal Novotny (:michal) 2012-03-27 01:22:33 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/c5d6aa6be62c
Comment 6 Ed Morley [:emorley] 2012-03-28 14:26:06 PDT
https://hg.mozilla.org/mozilla-central/rev/c5d6aa6be62c

Note You need to log in before you can comment on or make changes to this bug.