649194 - Abort when the cache IO thread can't be created

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Michal Novotny [:michal]]

Right now we don't fail to initialize the cache service when initialization of a cache IO thread fails (http://hg.mozilla.org/mozilla-central/annotate/94874a2f3bb3/netwerk/cache/nsCacheService.cpp#l1031). But we do try to dispatch events to this thread with no fallback in case the thread is not available. E.g. http://hg.mozilla.org/mozilla-central/annotate/94874a2f3bb3/netwerk/cache/nsCacheService.cpp#l732

I can't see a reason why creating a new thread should fail unless the process is experiencing some fatal problem, so IMO it makes sense to fail to initialize the cache service.

Comment 1

[Benjamin Smedberg]

I believe we should just NS_RUNTIMEABORT...

Comment 2

[Jason Duell]

> I believe we should just NS_RUNTIMEABORT...

+1

Comment 3

[Michal Novotny [:michal]]

Attachment: fix

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 609517 [details] [diff] [review]
fix

Review of attachment 609517 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 5

[Michal Novotny [:michal]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c5d6aa6be62c

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c5d6aa6be62c