649206 - clicking on recommended addon from about:home should highlight and ensure that addon is visible

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

currently if you click on a recommended addon it takes you to the addons panel, but not to the addon you clicked on. If you have more than ~8 addons the one you clicked on isn't even visible.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

This used to work

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch v1

Apparently this broke when bug 594795 landed, and changed the number of arguments to this function. I'm not sure when the return from appendSearchResults changed, but I changed it again later.

I started a test for this. Will try and get it done after we get green on the current ones.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 527801 [details] [diff] [review]
Patch v1

Oh boy. I can now see the two different changes that broke this. I think I may have added them both.

Yes, I test would be excellent.

Comment 4

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/mozilla-central/rev/e8de79122e19

Comment 5

[Anna (Waverley)]

VERIFIED FIXED on:

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110427 Firefox/6.0a1 Fennec /6.0a1

Device: HTC Desire Z (Android 2.2)