Closed Bug 649211 Opened 9 years ago Closed 9 years ago

PlacesDBUtils console output is broken


(Toolkit :: Places, defect)

Not set





(Reporter: mak, Assigned: mak)



(Keywords: regression, Whiteboard: [places-next-wanted])


(1 file, 1 obsolete file)

Attached patch patch v1.0 (obsolete) — Splinter Review
This is a regression from bug 609286, most likely I want to backport this to FF4, and if we miss FF5, to it as well.
Maintenance works, but it does not print any result to the console, and this is a users support regression, since we can't have users report us results of running it.
Attachment #525260 - Flags: review?(sdwilsh)
Attached patch patch v1.1Splinter Review
I forgot to hg add the test, it's really simple but all other stuff is checked by the existing test, so this just checks that we output to the console.
Attachment #525260 - Attachment is obsolete: true
Attachment #525260 - Flags: review?(sdwilsh)
Attachment #525262 - Flags: review?(sdwilsh)
Flags: in-testsuite?
Whiteboard: [places-next-wanted]
Blocks: 609286
Keywords: regression
Comment on attachment 525262 [details] [diff] [review]
patch v1.1

Attachment #525262 - Flags: review?(sdwilsh) → review+
Closed: 9 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Comment on attachment 525262 [details] [diff] [review]
patch v1.1

The patch is not scary and has a test. On Firefox 4 PlacesDBUtils works but it doesn't return any log to the user, we use these logs to figure out issues at the database level, so, as it is now, users can't report back problems to us.
I'd like to fix this in Firefox 4 that is the only version with a broken maintenance.
Attachment #525262 - Flags: approval2.0?
Comment on attachment 525262 [details] [diff] [review]
patch v1.1

not planning a further 4.0.x releases
Attachment #525262 - Flags: approval2.0? → approval2.0-
You need to log in before you can comment on or make changes to this bug.