Closed
Bug 649223
Opened 14 years ago
Closed 14 years ago
Reftest for bug 366207 wastes two seconds, needlessly
Categories
(Core :: XBL, defect)
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.60 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
See the discussion in bug 366207 comment 10 onwards.
|
Assignee | |
Comment 1•14 years ago
|
||
|
||
Comment 2•14 years ago
|
||
Comment on attachment 525291 [details] [diff] [review]
Patch (v1)
r=me
Attachment #525291 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
|
||
Comment 4•14 years ago
|
||
So this was tested on an older build to make sure it still triggered the assertion?
|
|
Assignee | |
Comment 5•14 years ago
|
||
(In reply to comment #4)
> So this was tested on an older build to make sure it still triggered the
> assertion?
No. As mentioned earlier, the test didn't really test anything useful in the first place, so there's no point in testing it on an earlier build.
|
|
||
Comment 6•14 years ago
|
||
Oh, why is the test there in the first place?
|
|
Assignee | |
Comment 7•14 years ago
|
||
(In reply to comment #6)
> Oh, why is the test there in the first place?
To catch other possible future failures. Tests are useful for other purposes behind regression testing the original change they're added for.
You need to log in
before you can comment on or make changes to this bug.
Description
•