Last Comment Bug 649223 - Reftest for bug 366207 wastes two seconds, needlessly
: Reftest for bug 366207 wastes two seconds, needlessly
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XBL (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla6
Assigned To: :Ehsan Akhgari
:
:
Mentors:
Depends on:
Blocks: 366207
  Show dependency treegraph
 
Reported: 2011-04-11 20:31 PDT by :Ehsan Akhgari
Modified: 2011-04-13 17:16 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (1.60 KB, patch)
2011-04-11 20:35 PDT, :Ehsan Akhgari
bzbarsky: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari 2011-04-11 20:31:27 PDT
See the discussion in bug 366207 comment 10 onwards.
Comment 1 :Ehsan Akhgari 2011-04-11 20:35:59 PDT
Created attachment 525291 [details] [diff] [review]
Patch (v1)
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2011-04-12 00:09:39 PDT
Comment on attachment 525291 [details] [diff] [review]
Patch (v1)

r=me
Comment 4 Martijn Wargers [:mwargers] (not working for Mozilla) 2011-04-13 11:22:44 PDT
So this was tested on an older build to make sure it still triggered the assertion?
Comment 5 :Ehsan Akhgari 2011-04-13 13:39:14 PDT
(In reply to comment #4)
> So this was tested on an older build to make sure it still triggered the
> assertion?

No.  As mentioned earlier, the test didn't really test anything useful in the first place, so there's no point in testing it on an earlier build.
Comment 6 Martijn Wargers [:mwargers] (not working for Mozilla) 2011-04-13 13:40:56 PDT
Oh, why is the test there in the first place?
Comment 7 :Ehsan Akhgari 2011-04-13 17:16:24 PDT
(In reply to comment #6)
> Oh, why is the test there in the first place?

To catch other possible future failures.  Tests are useful for other purposes behind regression testing the original change they're added for.

Note You need to log in before you can comment on or make changes to this bug.