Closed Bug 649238 Opened 13 years ago Closed 10 years ago

[css3-animations] nsAnimationManager should remove itself from nsRefreshDriver more aggressively

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: dbaron, Assigned: nrc)

References

Details

In order to keep the logic the same between transitions and animations, in bug 435442 I avoided removing the animation manager from the refresh driver when there are still animations whose state we need to track, but none of them need refreshing.  (I optimize away the refreshing of each individual animation that has completed or is paused, so the refresh is quick, but the animation manager is still registered with the refresh driver.)

We should change the registration/unregistration code so that the animation manager is not registered with the refresh driver when the mNeedsRefreshes of all ElementAnimations objects is false.
Summary: nsStyleAnimation should remove itself from nsRefreshDriver more aggressively → nsAnimationManager should remove itself from nsRefreshDriver more aggressively
Summary: nsAnimationManager should remove itself from nsRefreshDriver more aggressively → [css3-animations] nsAnimationManager should remove itself from nsRefreshDriver more aggressively
Largely if not completely fixed by bug 878142.
yeah, let's say this is fixed by https://hg.mozilla.org/mozilla-central/rev/28251f4140f6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → ncameron
Target Milestone: --- → mozilla25
See Also: → 978712
You need to log in before you can comment on or make changes to this bug.