649322 - Disable nightly updates for OSX 64bit

Status: VERIFIED FIXED

(Release Engineering :: General, defect)

Description

[Johnathan Nightingale [:johnath]]

Last night's landing of bug 386760 and some related updater fixes seems to have left OS X 64-bit perma-orange with an updater-related error.[1]

I haven't dug into the bustage and rs is probably asleep at the moment. Until we get that sorted out, let's disable nightly updates for these users so that we don't accidentally strand them with a broken updater.

[1] http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1302582482.1302593912.6040.gz&fulltext=1

Comment 1

[[e-mail] (:bhearsum)]

Disabled with:
[ffxbld@dm-ausstage01 mozilla-central]$ pwd
/opt/aus2/incoming/2/Firefox/mozilla-central
[ffxbld@dm-ausstage01 mozilla-central]$ chmod 700 Darwin_x86_64-gcc3

for now.

Comment 2

[[e-mail] (:bhearsum)]

It looks like I may not be around when these need turning back on. Instructions for doing so are:
- Be ffxbld@aus2-staging
- Run the following:
cd /opt/aus2/incoming/2/Firefox/mozilla-central
chmod 755 Darwin_x86_64-gcc3

Comment 3

[Robert Strong (they/them - no direct email)]

Note: the error is
/builds/slave/cen-osx64/build/obj-firefox/i386/dist/universal/firefox/Nightly.app /builds/slave/cen-osx64/build/obj-firefox/i386/tools/update-packaging
precomplete file is missing!
<a name='err0'></a><font color='000080'>make: *** [complete-patch] Error 1
</font>program finished with exit code 2

So, the updates are already not being generated because I added a requirement for the precomplete file to be in the mar.

Comment 4

[Robert Strong (they/them - no direct email)]

The problem here appears to be that it cd's into
cd universal/firefox/Nightly.app/Contents/MacOS

when it needs to cd into
cd universal/firefox/Nightly.app

Comment 5

[Robert Strong (they/them - no direct email)]

specifically
(cd universal/firefox/Nightly.app/Contents/MacOS && /tools/buildbot/bin/python2.6 /builds/slave/cen-osx64/build/config/createprecomplete.py)

needs to be

(cd universal/firefox/Nightly.app && /tools/buildbot/bin/python2.6 /builds/slave/cen-osx64/build/config/createprecomplete.py)

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

There are a couple of places where we have to munge the path used based on whether we are working with a Mac OS bundle and this is one of them. I could add additional checks such as checking two parent dirs up if the dir ends with .app but it seems like it really wouldn't add any value.

I'll be offline for a bit as I drive into the office so if Ted's not around if someone else could review I'd appreciate it.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 525480 [details] [diff] [review]
patch rev1

I hate Mac.

r=me

Comment 8

[Robert Strong (they/them - no direct email)]

I should have posted the patch in bug 386760... I'm going to move it over there and carry over the review.

Comment 9

[Robert Strong (they/them - no direct email)]

I should have posted the patch in bug 386760... I'm going to move it over there and carry over the review.

Comment 10

[Robert Strong (they/them - no direct email)]

I should have posted the patch in bug 386760... I'm going to move it over there and carry over the review.

Comment 11

[Robert Strong (they/them - no direct email)]

I should have posted the patch in bug 386760... I'm going to move it over there and carry over the review.

Comment 12

[Robert Strong (they/them - no direct email)]

dang bugzilla :(

Comment 13

[[e-mail] (:bhearsum)]

When bug 588746 is fixed, we can catch issues like this at check-in time.

Comment 14

[Robert Strong (they/them - no direct email)]

builds have gone green

Comment 15

[Nick Thomas [:nthomas] (UTC+12)]

I've turned mac updates back on, as described in comment #2. As rs says in comment #3 we never published any 20110412 build, so the 20110411 nightly is what's being offered (at least until a new nightly is done).

Comment 16

[WildcatRay]

Should automatic updates be working today (2011-04-14)?

Comment 17

[u279076]

(In reply to comment #16)
> Should automatic updates be working today (2011-04-14)?

I was able to get an update today through the About dialog as per normal.  Are you not able to?

Comment 18

[Robert Strong (they/them - no direct email)]

Also got a nightly
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110414 Firefox/6.0a1

Comment 19

[WildcatRay]

I tried on two computers separated by about 30 minutes or so and no updates were found. I will see what happens tomorrow. I installed Win32 build from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-aurora/

Comment 20

[Robert Strong (they/them - no direct email)]

Ray, this bug is Mac only

Comment 21

[u279076]

(In reply to comment #19)
> I tried on two computers separated by about 30 minutes or so and no updates
> were found. I will see what happens tomorrow. I installed Win32 build from
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-aurora/

Aurora builds do not get rebuilt every night (only mozilla-central), afaik.  Rob, feel free to correct me.

Comment 22

[Robert Strong (they/them - no direct email)]

You are correct

Comment 23

[WildcatRay]

But, this was the bug that was referred to for why Aurora was not automatic
updating. Must have been whoever or whatever referred me to this who had the
wrong bug. Sorry about this.

Comment 24

[u279076]

Ray, you should only see an update every day with the latest-mozilla-central nightlies.  Aurora will not see updates every day.  If you want the bleeding edge, you should be using latest-mozilla-central.

If you have any further updater issues, please file a new bug.  This bug was specific to Mac OSX 64-bit updates being disabled.

Thanks

Marking VERIFIED FIXED.

Comment 25

[LegNeato]

(In reply to comment #24)
> Ray, you should only see an update every day with the latest-mozilla-central
> nightlies.  Aurora will not see updates every day.  If you want the bleeding
> edge, you should be using latest-mozilla-central.
> 
> If you have any further updater issues, please file a new bug.  This bug was
> specific to Mac OSX 64-bit updates being disabled.
> 
> Thanks
> 
> Marking VERIFIED FIXED.

Aurora will be updating every day, out of the mozilla-aurora repo (as long as changes went in to the repo on that day). I told RelEng to turn that on yesterday but doesn't look to have stuck.

Comment 26

[WildcatRay]

The only reason I am "using" Aurora is because of covering for Peter on the
daily build thread while he is on holiday. Again, sorry.