Closed Bug 649400 Opened 13 years ago Closed 13 years ago

[css3-animations] should animate each property across the keyframes it's present in


(Core :: CSS Parsing and Computation, defect, P3)




Tracking Status
firefox5 --- fixed


(Reporter: dbaron, Assigned: dbaron)


(Keywords: dev-doc-complete)


(2 files)

It turns out I misextrapolated what the css3-animations spec meant to say about how keyframes work:  what WebKit does, I think, is that the animation animates each property across all the keyframes that it's present in (and using the initial values at 0% and 100% if needed)... as though the other keyframes weren't there.  So any property in the animation is present throughout the animation.

This behavior does make more sense for authors; it just didn't occur to me while reading the spec that it was what the spec might have meant (perhaps partly because my understanding of what the spec meant evolved over time, after reading it, as I tested things).
Assignee: nobody → dbaron
Priority: -- → P3
Target Milestone: --- → mozilla6
This fixes it.

In the new model, it wasn't clear to me how to handle inability to interpolate between some of the values.  The easiest thing to implement was to drop the entire property from the animation (even if there are some value pairs that we can interpolate between).  None of the other options felt particularly sensible with this model, and this was the easiest to implement.

I tested that the test fails without the patch and passes with it.
Attachment #527711 - Flags: review?(bzbarsky)
Comment on attachment 527711 [details] [diff] [review]
patch 2: main patch

Attachment #527711 - Flags: review?(bzbarsky) → review+
Attachment #527711 - Attachment description: patch → patch 2: main patch
I forgot I had this patch underneath the other one.  This fixes some index names that were getting a little out-of-hand.
Attachment #527724 - Flags: review?(bzbarsky)
Comment on attachment 527724 [details] [diff] [review]
patch 1: make index names clearer

Attachment #527724 - Flags: review?(bzbarsky) → review+
Are we going to put this on Aurora?
I'm documenting this as a change that will take place in Gecko 6.0; if it gets pulled into Gecko 5.0, someone please let me know.
Comment on attachment 527724 [details] [diff] [review]
patch 1: make index names clearer

I'd like to get this in to Aurora -- it's pretty silly to ship animations and then change the behavior substantially in the next release when we could avoid doing so.

This code doesn't affect anything outside of animations (so if we turn off animations, it all gets disabled).
Attachment #527724 - Flags: approval-mozilla-aurora?
Comment on attachment 527711 [details] [diff] [review]
patch 2: main patch

... and same for this patch.
Attachment #527711 - Flags: approval-mozilla-aurora?
Attachment #527711 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #527724 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I have updated the documentation to reflect that this has been accepted for Aurora.
You should know that Safari and Chrome differ in their treatment of "missing properties". Chrome tries to interpolate, Safari uses the intrinsic properties. I think a strict reading of the spec is that the Safari behavior (and the "pre-bug-fix" Firefox behavior) is the correct one, although it makes less sense.
You need to log in before you can comment on or make changes to this bug.