649442 - Add icons for branding to the extension

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Crowd Extension, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Once we have the icon for Mozmill Crowd we have to update the extension to include the branding, but also put the icon up on AMO.

Comment 1

[Aaron Train [:aaronmt]]

Attachment: icon (64x64) patch for extension

+ Adds the 64x64 icon from the asset package in bug 649450 patch to the extension folder

Comment 2

[Aaron Train [:aaronmt]]

I'll wait for your go-ahead to change the AMO icon to the 128x128 icon from the asset package in bug 649450

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 529884 [details] [diff] [review]
icon (64x64) patch for extension

Resetting for now because we will get a new icon. We also need two icons here 48x48 for the list view and 64x64 for the details view of the add-ons manager.

Comment 4

[Aaron Train [:aaronmt]]

Attachment: Screenshot

Only one file is needed, Firefox is smart enough to downsize a single icon for the listview, and use the 64x64 in the details view. See screenshot

Comment 5

[Aaron Train [:aaronmt]]

Attachment: new icon (64x64) patch for extension

+ new icon (64x64)

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 532191 [details] [diff] [review]
new icon (64x64) patch for extension

In the details view it looks great, but due to the nature of the icon it is way too massive in the list view. Just install other extensions and compare. As long as the most extensions don't use 48px wide icons I think we should use the 32x32 version of the icon in this case too.

Comment 7

[Aaron Train [:aaronmt]]

Attachment: 32x32 and 64x64 icons explicit reference

Ok, this adds the 32x32 and 64x64 icons to the skin folder and I explicitly reference them in the install manifest. The list view will use the 32x32 and the details view will use the 64x64 using icon64URL.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 532242 [details] [diff] [review]
32x32 and 64x64 icons explicit reference

Sweet. Lets get it landed.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I wonder if we should punt the addition of the icon on AMO until we really release the version 0.2.

Comment 10

[Aaron Train [:aaronmt]]

Landed as 

https://github.com/whimboo/mozmill-crowd/commit/57a86fdfd023d92fa6c40e88a0846426a8513d91

I think it should wait for 0.2.

Keep this bug open for reminder?

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

No, lets move it to the 0.2 tracking bug. Closing this bug as fixed. Thanks.