Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
JSFRAME_ASSIGNING is only used to tell js_InferFlags we are assigning.  This can be done more simply the way everywhere else does it: with JSAutoResolveFlags.  This came up in the context of bug 645901 when I was looking for places where we unnecessarily twiddle frame flags (thereby requiring frame deoptimization).
(Assignee)

Comment 1

6 years ago
Created attachment 525512 [details] [diff] [review]
do it
Attachment #525512 - Flags: review?(dvander)
Comment on attachment 525512 [details] [diff] [review]
do it

>+    uint32 opFormat = cs->format;

Nit: format is the canonical name elsewhere.

>+    uint32 setPropFlags = JOF_MODE(opFormat) == JOF_NAME

Nit: we follow K&R and parenthesize lower-than-unary-precedence ?: conditions.

JSFRAME_flagls: one down, 21 to go! :-P

/be
(Assignee)

Comment 3

6 years ago
Ah, good to know.  I doubt the flags will be dying any time soon (bug 645901 will avoid even storing them!), but the thing I'd really like to see go are these resolve flags.  Unfortunately, it seems like DOM global window quirks really want them...
Comment on attachment 525512 [details] [diff] [review]
do it

nice
Attachment #525512 - Flags: review?(dvander) → review+
(Assignee)

Updated

6 years ago
Whiteboard: fi
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/tracemonkey/rev/45d3b3a77929
Whiteboard: fi → fiixed-in-tracemonkey
(Assignee)

Comment 6

6 years ago
Srsly, fixed-in-tracemonkey.
Whiteboard: fiixed-in-tracemonkey → fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/45d3b3a77929
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.