The default bug view has changed. See this FAQ.

Needs to back out bug 59109 only from Aurora

RESOLVED FIXED in Firefox 5

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masayuki, Unassigned)

Tracking

5 Branch
mozilla5
Points:
---

Firefox Tracking Flags

(firefox5+ fixed)

Details

(Whiteboard: [aurora-backout])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 525597 [details] [diff] [review]
Patch

We need to back out bug 59109 due to it has a problem.

I asked about the aurora checkin rule in #introduction and to LegNeato. But LegNeato said that the rule isn't defined right now.

Temporary, I post a back out patch. And we should get approval for it.

I'm going to post the patch to tryserver.
(Reporter)

Comment 1

6 years ago
The patch makes new iid for nsIDOMCSS2Properties. And xbl-forms.css has been already removed from tree.

Updated

6 years ago
Whiteboard: [aurora-backout]
(In reply to comment #1)
> The patch makes new iid for nsIDOMCSS2Properties. And xbl-forms.css has been
> already removed from tree.

If it's not too complicated, a patch which disables this at compile time is preferred here, as this might live on trunk for a while before shipping it in a release...
I wouldn't worry about that; I think bug 647421 can happen quickly enough.
That said, I'd be fine with #ifdef-ing the new properties on mozilla-central.  Just don't #ifdef the other changes in the patch.
(Reporter)

Comment 5

6 years ago
(In reply to comment #3)
> I wouldn't worry about that; I think bug 647421 can happen quickly enough.

Do you think that the check in rule for aurora allows to fix bug 647421?
(In reply to comment #5)
> Do you think that the check in rule for aurora allows to fix bug 647421?

no.
backouts approved for aurora
tracking-firefox5: ? → +
(Reporter)

Comment 8

6 years ago
If we disable the feature by #ifdef, doesn't it cause "Unknown property" warnings due to forms.css? I'd like to back out by the patch.
For Aurora, back out the patch(es).
Attachment #525597 - Flags: approval-mozilla-aurora?

Updated

6 years ago
Attachment #525597 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Reporter)

Comment 10

6 years ago
http://hg.mozilla.org/mozilla-aurora/rev/da979a4892ac
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla5
(Reporter)

Updated

6 years ago
status-firefox5: --- → fixed
You need to log in before you can comment on or make changes to this bug.