649551 - Needs to back out bug 59109 only from Aurora

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

We need to back out bug 59109 due to it has a problem.

I asked about the aurora checkin rule in #introduction and to LegNeato. But LegNeato said that the rule isn't defined right now.

Temporary, I post a back out patch. And we should get approval for it.

I'm going to post the patch to tryserver.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The patch makes new iid for nsIDOMCSS2Properties. And xbl-forms.css has been already removed from tree.

Comment 2

[(no longer active)]

(In reply to comment #1)
> The patch makes new iid for nsIDOMCSS2Properties. And xbl-forms.css has been
> already removed from tree.

If it's not too complicated, a patch which disables this at compile time is preferred here, as this might live on trunk for a while before shipping it in a release...

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I wouldn't worry about that; I think bug 647421 can happen quickly enough.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That said, I'd be fine with #ifdef-ing the new properties on mozilla-central.  Just don't #ifdef the other changes in the patch.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #3)
> I wouldn't worry about that; I think bug 647421 can happen quickly enough.

Do you think that the check in rule for aurora allows to fix bug 647421?

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #5)
> Do you think that the check in rule for aurora allows to fix bug 647421?

no.

Comment 7

[Benjamin Smedberg]

backouts approved for aurora

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

If we disable the feature by #ifdef, doesn't it cause "Unknown property" warnings due to forms.css? I'd like to back out by the patch.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

For Aurora, back out the patch(es).

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://hg.mozilla.org/mozilla-aurora/rev/da979a4892ac