We need to back out bug 59109 due to it has a problem. I asked about the aurora checkin rule in #introduction and to LegNeato. But LegNeato said that the rule isn't defined right now. Temporary, I post a back out patch. And we should get approval for it. I'm going to post the patch to tryserver.
The patch makes new iid for nsIDOMCSS2Properties. And xbl-forms.css has been already removed from tree.
(In reply to comment #1) > The patch makes new iid for nsIDOMCSS2Properties. And xbl-forms.css has been > already removed from tree. If it's not too complicated, a patch which disables this at compile time is preferred here, as this might live on trunk for a while before shipping it in a release...
I wouldn't worry about that; I think bug 647421 can happen quickly enough.
That said, I'd be fine with #ifdef-ing the new properties on mozilla-central. Just don't #ifdef the other changes in the patch.
(In reply to comment #3) > I wouldn't worry about that; I think bug 647421 can happen quickly enough. Do you think that the check in rule for aurora allows to fix bug 647421?
(In reply to comment #5) > Do you think that the check in rule for aurora allows to fix bug 647421? no.
If we disable the feature by #ifdef, doesn't it cause "Unknown property" warnings due to forms.css? I'd like to back out by the patch.
For Aurora, back out the patch(es).
Attachment #525597 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla5
Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(no pain of the broken bone, but the corset blocks me to concentrate)Reporter
9 years ago
You need to log in before you can comment on or make changes to this bug.