Closed Bug 649564 Opened 14 years ago Closed 13 years ago

Intermittent failure in test_socks.js | test failed (with xpcshell return code: 0) | Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProcess.kill]

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12
Tracking Flags:
Tracking Status
firefox-esr10 --- fixed

People

(Reporter: philor, Assigned: michal)

References

Details

(Keywords: intermittent-failure, Whiteboard: [qa-])

Attachments

(1 file)

Try to ensure that the socks client subprocess is never killed after the process completes.
1.22 KB, patch
lsblakk
: approval-mozilla-esr10+
Details | Diff | Splinter Review
At least the second time, but last time I wasn't in the mood to file. http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1302664155.1302665145.18596.gz Rev3 MacOSX Leopard 10.5.8 mozilla-central opt test xpcshell on 2011/04/12 20:09:15 s: talos-r3-leopard-026 TEST-INFO | /Users/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_socks.js | running test ... TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_socks.js | test failed (with xpcshell return code: 0), see following log: ... TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_socks.js | [null : 402] abcdefg.xxx == abcdefg.xxx server: all tests completed server: client closed! TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_socks.js | [null : 112] 8 == 8 server: test finished 8003 TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_socks.js | [null : 397] true == true TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_socks.js | [null : 398] socks == socks TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_socks.js | [null : 399] 8003 == 8003 TEST-PASS | /Users/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_socks.js | [null : 402] abcdefg.xxx == abcdefg.xxx TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/head.js | exception thrown from do_timeout callback: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProcess.kill]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_socks.js :: <TOP_LEVEL> :: line 446" data: no] - See following stack: JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: do_throw :: line 444 JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: <TOP_LEVEL> :: line 158 TEST-INFO | (xpcshell/head.js) | exiting test <<<<<<<
Assignee: nobody → michal.novotny
That thing where it failed 11 times in the first half of January, and then failed 30 times yesterday and today? Yeah, somebody should be worrying about that.
I don't see anything incriminating landing on inbound in the range of the 14th to the 17. It's conceivable that the test is simply wrong, and we started tickling it for unknown reasons - as far as I can tell, it's illegal to call kill() after the process has completed, but we have a timer in the test that calls it regardless, since we never reset this.client_subprocess to null (http://mxr.mozilla.org/mozilla-central/source/netwerk/test/unit/test_socks.js#446).
I guess I could try retriggering this a bunch of times on try, or we could throw it at inbound and see if it makes a difference.
Try run for 989429c02b1e is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=989429c02b1e Results (out of 8 total builds): success: 8 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/josh@joshmatthews.net-989429c02b1e
Are these new instances before or after your checkin?
Before.
Well, that didn't work. It failed on my push :(
That 'un is after, though :(
I've pushed a patch that should stop the oranges we're seeing right now. http://hg.mozilla.org/integration/mozilla-inbound/rev/8f06957d69d9
https://tbpl.mozilla.org/php/getParsedLog.php?id=8785699&tree=Firefox Rev3 Fedora 12 mozilla-central pgo test xpcshell on 2012-01-24 04:07:42 PST for push cfaee7b043f7
Looks fixed on m-c to me.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
status-firefox-esr10: --- → affected
Target Milestone: --- → mozilla12
Comment on attachment 589457 [details] [diff] [review] Try to ensure that the socks client subprocess is never killed after the process completes. [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: [orange] fix Fix Landed on Version: Fx12 and higher Risk to taking this patch (and alternatives if risky): Test-only change String or UUID changes made by this patch: None See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #589457 - Flags: approval-mozilla-esr10?
Comment on attachment 589457 [details] [diff] [review] Try to ensure that the socks client subprocess is never killed after the process completes. test-only fix, approving for esr.
Attachment #589457 - Flags: approval-mozilla-esr10? → approval-mozilla-esr10+
Flags: in-testsuite+
Whiteboard: [orange] → [orange][qa-]
Whiteboard: [orange][qa-] → [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: