Closed Bug 649566 Opened 9 years ago Closed 9 years ago
@keyframe(s) missing from <style> sanitizing code in ns
HTMLFragment Content Sink
This code contains case statements for every other CSS rule type so should probably have the keyframe(s) rule types too.
The code is missing DOCUMENT_RULE too.
It should really also: (a) have a default: case, and set didSanitize to true in that case (b) handle a bunch of the rule classes it explicitly doesn't handle
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #526076 - Flags: review?(bzbarsky)
Comment on attachment 526076 [details] [diff] [review] Patch (v1) r=me, but file a followup on maybe leaving the group rules in but sanitizing their contents?
Attachment #526076 - Flags: review?(bzbarsky) → review+
Filed bug 650094. CCing Henri as this patch probably steps on his tows...
(In reply to comment #7) > CCing Henri as this patch probably steps on his tows... Thanks. Whichever of the patch here and or the patch for bug 482909 lands first causes the patch for the other one to rot in such a way that eventually the fix here has to be rewritten on top of bug 482909.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Comment on attachment 526076 [details] [diff] [review] Patch (v1) a=dbaron for mozilla-aurora (from triage meeting)
Attachment #526076 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.