649593 - TI+JM: v8 benchmark harness correctness bug

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Testcase

Attached testcase demonstrates the problem. It fails with -m -n -a:
test.js:20: Error: Assertion failed: got 0, expected 6326624

Comment 1

[Jan de Mooij [:jandem]]

Reduced further:
--
function RunSingleBenchmark(data) {
    if (data == null)
        return { runs: 0, elapsed: 0 };
    data.runs += 10;
    return data;
}
var data;
data = RunSingleBenchmark(data);
data = RunSingleBenchmark(data);
assertEq(data.runs, 10);
--

Comment 2

[Christian Holler (:decoder)]

Cannot be reproduced on 64 bit, seems to be a 32 bit only problem. Jan suggested it might be related to register allocation.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Patch

Use stubcc.masm to load atom pointer for OOL SetName call.

Comment 4

[Brian Hackett [Laid off!]]

Comment on attachment 525646 [details] [diff] [review]
Patch

Oops. At least I remembered to store the atom at all!

Comment 5

[Brian Hackett [Laid off!]]

Thanks!

http://hg.mozilla.org/projects/jaegermonkey/rev/2ad374159c49