TI+JM: v8 benchmark harness correctness bug

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 525641 [details]
Testcase

Attached testcase demonstrates the problem. It fails with -m -n -a:
test.js:20: Error: Assertion failed: got 0, expected 6326624
(Assignee)

Comment 1

6 years ago
Reduced further:
--
function RunSingleBenchmark(data) {
    if (data == null)
        return { runs: 0, elapsed: 0 };
    data.runs += 10;
    return data;
}
var data;
data = RunSingleBenchmark(data);
data = RunSingleBenchmark(data);
assertEq(data.runs, 10);
--
Cannot be reproduced on 64 bit, seems to be a 32 bit only problem. Jan suggested it might be related to register allocation.
Hardware: All → x86
(Assignee)

Comment 3

6 years ago
Created attachment 525646 [details] [diff] [review]
Patch

Use stubcc.masm to load atom pointer for OOL SetName call.
Assignee: general → jandemooij
Status: NEW → ASSIGNED
Attachment #525646 - Flags: review?(bhackett1024)
Comment on attachment 525646 [details] [diff] [review]
Patch

Oops. At least I remembered to store the atom at all!
Attachment #525646 - Flags: review?(bhackett1024) → review+
Thanks!

http://hg.mozilla.org/projects/jaegermonkey/rev/2ad374159c49
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.