649754 - update dialog no longer centered

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

fallout from WinCE removal in bug 386760

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: simple fix

Add back the call to CenterDialog

Comment 2

[Robert Strong (they/them - no direct email)]

Simple fix, just adds back a function call that was accidentally removed. I think we want this on Aurora

Comment 3

[LegNeato]

How far is it off? Can it get off screen?

Comment 4

[Robert Strong (they/them - no direct email)]

Upper left corner

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/704c27a2a2e4

Don't think we need tests for this. Besides it being a royal pita to create tests for this every Windows nightly update sees this ui so it is hard to miss.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 525767 [details] [diff] [review]
simple fix

Restores one line of code that was accidentally removed in the rush to get bug 386760 landed for Aurora. Risks are extremely negligible since this is the same code that is on several releases.

Comment 7

[Asa Dotzler [:asa]]

I think we must have this in Aurora. Without it, the dialog is slammed into the top left of the desktop. That's not a shippable regression IMO.

Comment 8

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-aurora
http://hg.mozilla.org/mozilla-aurora/rev/6b33dec92aaa