The default bug view has changed. See this FAQ.

Don't force *.chk in MARs

RESOLVED FIXED

Status

Release Engineering
General Automation
P5
normal
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: rail, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [updates])

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Bug 313956 fixes bug 404340, so probably it would be better to not force *.chk files in update.manifest.
(Reporter)

Comment 1

6 years ago
Created attachment 525784 [details] [diff] [review]
patcher-configs
Attachment #525784 - Flags: feedback?(nrthomas)
(Reporter)

Comment 2

6 years ago
Created attachment 525785 [details] [diff] [review]
update-packaging
Attachment #525785 - Flags: feedback?(nrthomas)
(Reporter)

Comment 3

6 years ago
Created attachment 525786 [details] [diff] [review]
tools
Attachment #525786 - Flags: feedback?(nrthomas)
Do the zip builds also use the same .chk files? I'm not terribly concerned if they don't but there will likely be app update bug reports for failing partials if they aren't the same.
(Reporter)

Comment 5

6 years ago
(In reply to comment #4)
> Do the zip builds also use the same .chk files? 

AFAIK, zip files are used only for tests. We don't use them for MAR generation.
(Reporter)

Comment 6

6 years ago
FTR, see also bug 404340 comment 44 and below.
Nightly users also download zip builds and update from them. So, when a nightly user downloads a zip build and the next day gets a partial update if the chk files don't match the partial will fail.

This change basically moves the problem over to people using zips. IMO that is better than where we were and don't really think it is a case that needs to be fixed. iirc there is also a bug for generating the zips from the installer as well which would also fix it.
(In reply to comment #7)
> Nightly users also download zip builds and update from them. So, when a nightly
> user downloads a zip build and the next day gets a partial update if the chk
> files don't match the partial will fail.
> 
> This change basically moves the problem over to people using zips. IMO that is
> better than where we were and don't really think it is a case that needs to be
> fixed. iirc there is also a bug for generating the zips from the installer as
> well which would also fix it.

ZIP users can fall back to completes in the meantime.
Agreed... just popped in to verify my suspicion that partials for zip builds will fail so if I get bug reports I can move them to the correct component vs. trying to figure out whether or not something with app update broke. Thanks!
Comment on attachment 525784 [details] [diff] [review]
patcher-configs

I don't think we can do this if bug 313956 has only landed on m-c.
Attachment #525784 - Flags: feedback?(nrthomas) → feedback-
Comment on attachment 525785 [details] [diff] [review]
update-packaging

This seems fine to land anywhere bug 313956 has landed.
Attachment #525785 - Flags: feedback?(nrthomas) → feedback+
Comment on attachment 525786 [details] [diff] [review]
tools

This seems fine for new configs on new branches (where bug 313956 has landed).
Attachment #525786 - Flags: feedback?(nrthomas) → feedback+
(Reporter)

Comment 13

6 years ago
Back to pool, maybe next Q...
Assignee: rail → nobody

Updated

5 years ago
Component: Release Engineering → Release Engineering: Automation (General)
QA Contact: release → catlee
Whiteboard: [updates]
(Assignee)

Updated

4 years ago
Product: mozilla.org → Release Engineering
We stopped doing this a long time ago, probably around the same time bug 404340 ang bug 489961 were fixed.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.