64979 - Back & Forward corrupted by redirected URLs

Status: VERIFIED DUPLICATE of bug 39938

(Core :: DOM: Navigation, defect)

Description

[Becki Sanford]

From Bugzilla Helper:
User-Agent: Mozilla/4.72 [en] (X11; U; Linux 2.4.0-test10 i686)
BuildID:    Mozilla 0.7 and build ID 2001011008)

Forward & back buttons not working if a URL is redirected.  Back button gets
"stuck" on site.  Once back at redirected site, both back and forward buttons
raise exceptions.

Reproducible: Always
Steps to Reproduce:
1.Open browser
2.Go to http://www.mozilla.org
3.Go to http://www.startribune.com/variety  (major redirection)
4.Go to http://www.petsmart.com  (no redirection)
5.Click on Back button
6.Click on Back button again

Actual Results:  Step #5 appears to work correctly, however step #6 does NOT go
to back mozilla.org.  It's stuck on variety.


Expected Results:  Expect step #6 to go to www.mozilla.org

If you look at the back dropdown menu after step #5, there's an entry for
"Variety" which shouldn't be there.

If you look at the forward dropdown menu after step #5, there are NO entries
even though the button is enabled.  There should be an entry for "Petsmart".

The following error occurs with step #6 or if you click on the Forward button:

JavaScript error: 
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x8000ffff (NS_ERROR_UNEXPECTED) [nsIWebNavigation.goForward]"  nsresult:
"0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
chrome://navigator/content/navigator.js :: BrowserForward :: line 523"  data:
no]

Comment 1

[Becki Sanford]

NOTE: The example works just fine with Mozilla M18 (build ID 2000101015).

Comment 2

[Asa Dotzler [:asa]]

over to History.

Comment 3

[Eugene Savitsky]

I do see this on win2000.

moz 2001011804

Comment 4

[Becki Sanford]

Changed status to "major" since there is a major loss of function if the forward
and back buttons don't work properly.  This is quite important nowdays with the
majority of websites redirecting their URLs.

Comment 5

[Becki Sanford]

Not sure if this helps, but I don't think nsDocShell::AddChildSHEntry() should
be calling CloneAndReplace() if the cloneID = 0 (which it will be if the
aCloneRef is null).

Comment 6

[Becki Sanford]

Something like the following appears to work:

    if (currentEntry) {
      PRUint32 cloneID=0;
      nsCOMPtr<nsISHEntry> nextEntry;
//(do_CreateInstance(NS_SHENTRY_CONTRACTID));
      //   NS_ENSURE_TRUE(result, NS_ERROR_FAILURE);
      if (aCloneRef)
          aCloneRef->GetID(&cloneID);
      if (cloneID > 0) {
        rv = CloneAndReplace(currentEntry, cloneID, aNewEntry,
                             getter_AddRefs(nextEntry));
          
        if (NS_SUCCEEDED(rv)) {
          rv = mSessionHistory->AddEntry(nextEntry, PR_TRUE);
        }
      }
    }

Comment 7

[Radha on family leave (not reading bugmail)]

*** This bug has been marked as a duplicate of 39938 ***

Comment 8

[sairuh (rarely reading bugmail)]

mass-verifying Duplicate bugs which haven't changed since 2001.12.31.

set your search string in mail to "CitizenGKar" to filter out these messages.