649983 - Use more vertical space for dialogs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

The dialog theme changes in Bug 618989 reduced the maxHeight we use on dialogs, limiting the amount of content we can show in a large dialog.

Let's extend the maxHeight to match the margin on the width.

Comment 1

[Cristian Nicolae (:xti)]

Attachment: screenshot

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: example of unused area above and below dialog

You can see in this screenshot that the dialog content is limited because of the extra space left above and below the dialog.

Using more vertical space will help some dialogs display more content.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This happens because of rule
.perm-modal-block {
  -moz-box-align: center;
}

This rule force the box to fit the size of it's content but fail for some reason in this case.
I don't think we want to remove this rule since it makes things simplier for all the other dialogs. For example adding some padding at the bottom of the box with the class prompt-message fix this bug (not sure why thouhg)

Comment 5

[Philipp von Weitershausen [:philikon]]

Plz to be fixing this for Firefox 5 kthxbai :)

Comment 6

[Wesley Johnston (:wesj)]

Attachment: HackyPatch

Hack to add pading like vivien suggested, and only apply it to the sync dialog.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 536915 [details] [diff] [review]
HackyPatch

Tested on nexus one or some device that showed it fixed the issues, I assume

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

A small comment before check-in would be nice if we don't want this hack to be removed during a clean-up.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mozilla-central/rev/414c88582e9f

Comment 10

[Aaron Train [:aaronmt]]

Attachment: Nightly (06/14)

Is this correct? See attached screenshot. Looks like it still needs a height tweak adjustment.

Comment 11

[Philipp von Weitershausen [:philikon]]

(In reply to comment #10)
> Is this correct? See attached screenshot.

No. I see no change at all! Should we reopen?

Comment 12

[Wesley Johnston (:wesj)]

probably due to the gingerbread theme

Comment 13

[Wesley Johnston (:wesj)]

Attachment: Gingerbread Patch

Follow up patch for gingerbread.

Comment 14

[Matt Brubeck (:mbrubeck)]

Gingerbread patch merged from mozilla-inbound to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/e10723691732

Comment 15

[Aaron Train [:aaronmt]]

Verified fixed
Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110616 Firefox/7.0a1 Fennec/7.0a1