The default bug view has changed. See this FAQ.

Use more vertical space for dialogs

VERIFIED FIXED in Firefox 7

Status

Fennec Graveyard
General
P3
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: mfinkle, Assigned: wesj)

Tracking

Trunk
Firefox 7
x86
Linux

Details

Attachments

(5 attachments)

The dialog theme changes in Bug 618989 reduced the maxHeight we use on dialogs, limiting the amount of content we can show in a large dialog.

Let's extend the maxHeight to match the margin on the width.
Created attachment 525986 [details]
screenshot
Created attachment 525987 [details]
example of unused area above and below dialog

You can see in this screenshot that the dialog content is limited because of the extra space left above and below the dialog.

Using more vertical space will help some dialogs display more content.

Updated

6 years ago
Priority: -- → P3
This happens because of rule
.perm-modal-block {
  -moz-box-align: center;
}

This rule force the box to fit the size of it's content but fail for some reason in this case.
I don't think we want to remove this rule since it makes things simplier for all the other dialogs. For example adding some padding at the bottom of the box with the class prompt-message fix this bug (not sure why thouhg)

Updated

6 years ago
Duplicate of this bug: 658938
Plz to be fixing this for Firefox 5 kthxbai :)
status-firefox5: --- → affected
(Assignee)

Comment 6

6 years ago
Created attachment 536915 [details] [diff] [review]
HackyPatch

Hack to add pading like vivien suggested, and only apply it to the sync dialog.
Attachment #536915 - Flags: review?(mark.finkle)
Comment on attachment 536915 [details] [diff] [review]
HackyPatch

Tested on nexus one or some device that showed it fixed the issues, I assume
Attachment #536915 - Flags: review?(mark.finkle) → review+
A small comment before check-in would be nice if we don't want this hack to be removed during a clean-up.
http://hg.mozilla.org/mozilla-central/rev/414c88582e9f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7

Updated

6 years ago
Assignee: nobody → wjohnston
Created attachment 539206 [details]
Nightly (06/14)

Is this correct? See attached screenshot. Looks like it still needs a height tweak adjustment.
(In reply to comment #10)
> Is this correct? See attached screenshot.

No. I see no change at all! Should we reopen?
(Assignee)

Comment 12

6 years ago
probably due to the gingerbread theme
(Assignee)

Comment 13

6 years ago
Created attachment 539243 [details] [diff] [review]
Gingerbread Patch

Follow up patch for gingerbread.
Attachment #539243 - Flags: review?(mark.finkle)
(Reporter)

Updated

6 years ago
Attachment #539243 - Flags: review?(mark.finkle) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [inbound]
Gingerbread patch merged from mozilla-inbound to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/e10723691732
Whiteboard: [inbound]
Verified fixed
Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110616 Firefox/7.0a1 Fennec/7.0a1
Status: RESOLVED → VERIFIED
(Assignee)

Updated

6 years ago
status-firefox7: --- → fixed
You need to log in before you can comment on or make changes to this bug.