The dialog theme changes in Bug 618989 reduced the maxHeight we use on dialogs, limiting the amount of content we can show in a large dialog.
Let's extend the maxHeight to match the margin on the width.
Created attachment 525986 [details]
Created attachment 525987 [details]
example of unused area above and below dialog
You can see in this screenshot that the dialog content is limited because of the extra space left above and below the dialog.
Using more vertical space will help some dialogs display more content.
This happens because of rule
This rule force the box to fit the size of it's content but fail for some reason in this case.
I don't think we want to remove this rule since it makes things simplier for all the other dialogs. For example adding some padding at the bottom of the box with the class prompt-message fix this bug (not sure why thouhg)
*** Bug 658938 has been marked as a duplicate of this bug. ***
Plz to be fixing this for Firefox 5 kthxbai :)
Created attachment 536915 [details] [diff] [review]
Hack to add pading like vivien suggested, and only apply it to the sync dialog.
Comment on attachment 536915 [details] [diff] [review]
Tested on nexus one or some device that showed it fixed the issues, I assume
A small comment before check-in would be nice if we don't want this hack to be removed during a clean-up.
Created attachment 539206 [details]
Is this correct? See attached screenshot. Looks like it still needs a height tweak adjustment.
(In reply to comment #10)
> Is this correct? See attached screenshot.
No. I see no change at all! Should we reopen?
probably due to the gingerbread theme
Created attachment 539243 [details] [diff] [review]
Follow up patch for gingerbread.
Gingerbread patch merged from mozilla-inbound to mozilla-central:
Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110616 Firefox/7.0a1 Fennec/7.0a1