649997 - Remove use of no-longer-needed out param nsresult on nsIHTMLCollection

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

Now that we have infallible new, the table code can no longer fail.  Patches coming up to remove the gunk.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Stop touching rv in DO_FOR_EACH_ROWGROUP on table rows collections.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: diff -w of part 1, just in case

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Change nsIHTMLCollection::GetNodeAt to not use an nsresult outparam.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Change nsIHTMLCollection::GetNodeAt to not use an nsresult outparam.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Change nsIHTMLCollection::GetNamedItem to not use an nsresult outparam.

Comment 6

[Peter Van der Beken [:peterv]]

Comment on attachment 525993 [details] [diff] [review]
part 1.  Stop touching rv in DO_FOR_EACH_ROWGROUP on table rows collections.

This relies on GetTHead/GetTBodies/GetTFoot never returning an error except OOM. Could we replace GetTHead/GetTFoot with nsHTMLTableElement::GetSection (would need to make it public) and maybe have a nsHTMLTableElement::GetTBodies that returns a nsContentList*? nsHTMLTableElement::GetSection should also return a nsIContent*, but I disgress :-/.

Comment 7

[Boris Zbarsky [:bzbarsky]]

> nsHTMLTableElement::GetSection should also return a nsIContent*

That would involve QIs at all the callsites.  I don't think that really helps anything.

I added public inline GetTHead and GetTFoot methods that take no args and don't fail and that call GetSection() appropriately.  I then made the existing GetTHead and GetTFoot use those, and made DO_FOR_EACH_ROWGROUP do likewise.

I added a TBodies() function that returns nsContentList and used it in DO_FOR_EACH_ROWGROUP as well.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Interdiff for the part 1 changes

Comment 9

[Boris Zbarsky [:bzbarsky]]

Pushed:

  http://hg.mozilla.org/mozilla-central/rev/05d0635e2840
  http://hg.mozilla.org/mozilla-central/rev/55e55b249876
  http://hg.mozilla.org/mozilla-central/rev/23b222c43690

then pushed http://hg.mozilla.org/mozilla-central/rev/b1c530bf15f3 to fix an issue ms2ger noticed in patch2.

Comment 10

[Peter Van der Beken [:peterv]]

(In reply to comment #8)
> Interdiff for the part 1 changes

Sweet, thanks!

(In reply to comment #9)
> then pushed http://hg.mozilla.org/mozilla-central/rev/b1c530bf15f3 to fix an
> issue ms2ger noticed in patch2.

Ouch, sorry for missing that :-(.