buildslave should not exit on UnauthorizedLogin

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: dustin, Assigned: dustin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [buildbot], URL)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Exiting in this condition makes sense for buildbot itself - if you've got the wrong password, there's no sense in retrying.  But it doesn't make sense for Mozilla, since we'll end up having to touch the slave.
(Assignee)

Comment 1

7 years ago
For my reference, here's the error.  It's actually an unhandled error, rather than a specific check for UnauthorizedLogin:

2011-06-08 15:36:32-0700 [-] Log opened.
2011-06-08 15:36:32-0700 [-] twistd 10.2.0 (/tools/buildbot-0.8.4-pre-moz1/bin/python 2.6.5) starting up.
2011-06-08 15:36:32-0700 [-] reactor class: twisted.internet.selectreactor.SelectReactor.
2011-06-08 15:36:32-0700 [-] Starting factory <buildslave.bot.BotFactory instance at 0xa0031cc>
2011-06-08 15:36:32-0700 [-] Connecting to preproduction-master.build.sjc1.mozilla.com:9010
2011-06-08 15:36:32-0700 [Broker,client] ReconnectingPBClientFactory.failedToGetPerspective
2011-06-08 15:36:32-0700 [Broker,client] Unhandled Error
        Traceback from remote host -- Traceback (most recent call last):
        Failure: twisted.cred.error.UnauthorizedLogin: 
        
2011-06-08 15:36:32-0700 [Broker,client] Lost connection to preproduction-master.build.sjc1.mozilla.com:9010
2011-06-08 15:36:32-0700 [Broker,client] Stopping factory <buildslave.bot.BotFactory instance at 0xa0031cc>
2011-06-08 15:36:32-0700 [-] Main loop terminated.
2011-06-08 15:36:32-0700 [-] Server Shut Down.
(Assignee)

Updated

7 years ago
(Assignee)

Comment 2

7 years ago
Created attachment 538568 [details] [diff] [review]
m650004-buildbot-r1-p1.patch
Attachment #538568 - Flags: review?(catlee)

Updated

6 years ago
Attachment #538568 - Flags: review?(catlee) → review+
(Assignee)

Comment 3

6 years ago
Landed in 043788f30afc on the default branch (where it doesn't really matter) and 364f3b1e6352 on the slaves branch, although that's not deployed anywhere.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.