650036 - Firefox 4 on Linux doesn't show Bookmarks button next to Home button in toolbar

Status: RESOLVED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[Daniel Holbert [:dholbert]]

Comparing these firstrun screenshots...
http://www.mozilla.com/img/firefox/4.0/firstrun/screenshot-mac.png
http://www.mozilla.com/img/firefox/4.0/firstrun/screenshot-win.png
http://www.mozilla.com/img/firefox/4.0/firstrun/screenshot-linux.png
... shows that the on Linux, we lack a 'bookmarks' button at the right edge of the toolbar. (to the right of the Home button)

If I invoke "Customize Toolbars", then the bookmark button magically appears while the customize dialog is open -- but as soon as I leave customize-mode, the bookmark button disappears again.

Surely this isn't intentional?

Comment 1

[Daniel Holbert [:dholbert]]

This behavior persists in the latest Nightly on Linux, btw.
Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110413 Firefox/6.0a1

Note that this makes our firstrun & "get to know Firefox" diagrams wrong/confusing/misleading for Linux users.  See bug 649856 & bug 649860.

Comment 2

[Marco Bonardo [:mak]]

The fact the button is not present is intentional when the menubar is visible (for now). That button is intended as a quick replacement of the Bookmarks menu.
The fact it appears and changes in Customize mode is not, but is a dupe of bug 581238.

Comment 3

[Daniel Holbert [:dholbert]]

Ah, right -- if I hide the menu bar, then the bookmark button shows up.

So the distinction is:
* On Windows, the Menu Bar is hidden by default, so bookmark button shows up.
* On Linux, the Menu Bar is shown by default, so bookmark button is hidden.
(and on Mac, the menu bar is the system-menu-bar at top of screen, and bookmark button is always there)

Comment 4

[Daniel Holbert [:dholbert]]

I guess that makes this INVALID.  I'll update the bugs in Comment 1 with a note on the different default behavior on Linux & the need to update the diagrams there.

Comment 5

[Kohei Yoshino [:kohei]]

On Ubuntu 11.04, the bundled/semiofficial Firefox has an add-on called Globel Menubar Integration to combine the menubar with the Unity menu panel (like Mac OS X), so we cannot hide the menubar.

Comment 6

[Marco Bonardo [:mak]]

yes, unity is a special case, you could file a bug apart for it, btw there are plans to make the button always visible and move the star from the locationbar to it, so that would mostly solve any craziness, just that I don't have any schedule on this plan.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

>So the distinction is:
>* On Windows, the Menu Bar is hidden by default, so bookmark button shows up.
>* On Linux, the Menu Bar is shown by default, so bookmark button is hidden.
>(and on Mac, the menu bar is the system-menu-bar at top of screen, and bookmark
>button is always there)

Yeah that is pretty confusing (although mitigated by the assumption that we believe the vast majority of users aren't encountering Firefox on different platforms throughout their day).  We need to clean this up.