650080 - nsContentEventHandler.cpp:867: warning: unused variable 'pEventWidget'

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

Filing bug on this warning:
> nsContentEventHandler.cpp:867: warning: unused variable 'pEventWidget'

Code in question (added in bug 627649):
> 856   if (contentUnderMouse) {
[...]
> 867     nsIWidget* pEventWidget = aEvent->widget.get();
> 868   }

The variable is created right at the end of an "if" check, and it immediately goes out of scope without ever being used:

I'm assuming line 867 can just be removed entirely. smichaud, is that correct?

Comment 1

[Daniel Holbert [:dholbert]]

Meant to link to source in MXR:
http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsContentEventHandler.cpp#867
and cset that added this:
http://hg.mozilla.org/mozilla-central/diff/75082063f8e6/content/events/src/nsContentEventHandler.cpp#l1.68

Comment 2

[Daniel Holbert [:dholbert]]

...and meant to CC smichaud for an answer to the end of comment 0.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

> I'm assuming line 867 can just be removed entirely. smichaud, is
> that correct?

Yes.

It's something left over from my debug build, which I forgot to
remove.

Thanks for catching this, and sorry for the confusion.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

And I even had a patch for it!

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 526082 [details] [diff] [review]
Patch v1

Looks good to me :-)

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/400353278933