650081 - Fix ipc_channel_win.cpp WARNING about Connect called twice

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Benjamin Stover (:stechz)]

I noticed that we were getting a strange warning on Windows IPC builds:
WARNING: Connect called twice: file e:/builds/moz2_slave/try-w32-dbg/build/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 178

This was fixed over a year ago in Chromium:
http://src.chromium.org/viewvc/chrome/trunk/src/ipc/ipc_channel_win.cc?revision=23569&view=markup

Perhaps we should consider updating to a more recent version?

Comment 1

[Benjamin Stover (:stechz)]

Obviously a warning isn't a good reason to upgrade, but I'm sure there are legitimate fixes and other improvements we may want.

Comment 2

[Josh Matthews [:jdm]]

cjones and bent should be in on this as well.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This warning has been known to be spurious forever and has been ignored.  Not worth bothering with IMHO.

We can't just pull from upstream because the chromium stuff has been rewritten several times since our initial import.  We've cherry-picked bug fixes when needed.  We're not interested in sharing the ipc/chromium code as written (for a variety of reasons), so it wouldn't make sense for us to spend time on it except for security bugs or big perf wins.

Unless you want to morph this bug to something more specific, like pulling a fix for the spurious warning, this bug is a WONTFIX.

Comment 4

[Benjamin Stover (:stechz)]

Morphing to a fix for the warning then.

Comment 5

[Benjamin Stover (:stechz)]

Attachment: Fix ipc_channel_win.cpp WARNING about Connect called twice

Comment 6

[Benjamin Stover (:stechz)]

Attachment: Fix ipc_channel_win.cpp WARNING about Connect called twice

Used "try" as my compiler, and it fails. :/ Is it OK to just remove the darn
warning?

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 526131 [details] [diff] [review]
Fix ipc_channel_win.cpp WARNING about Connect called twice

Yeah.  Let's just wrap it in #ifndef CHROMIUM_MOZILLA_BUILD.

Comment 8

[Benjamin Stover (:stechz)]

Pushed http://hg.mozilla.org/mozilla-central/rev/e60b8be7a97b

Comment 9

[Dão Gottwald [:dao]]

bugspam