The default bug view has changed. See this FAQ.

Fix ipc_channel_win.cpp WARNING about Connect called twice

RESOLVED FIXED

Status

()

Core
IPC
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: stechz, Assigned: stechz)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
I noticed that we were getting a strange warning on Windows IPC builds:
WARNING: Connect called twice: file e:/builds/moz2_slave/try-w32-dbg/build/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 178

This was fixed over a year ago in Chromium:
http://src.chromium.org/viewvc/chrome/trunk/src/ipc/ipc_channel_win.cc?revision=23569&view=markup

Perhaps we should consider updating to a more recent version?
(Assignee)

Comment 1

6 years ago
Obviously a warning isn't a good reason to upgrade, but I'm sure there are legitimate fixes and other improvements we may want.

Comment 2

6 years ago
cjones and bent should be in on this as well.
This warning has been known to be spurious forever and has been ignored.  Not worth bothering with IMHO.

We can't just pull from upstream because the chromium stuff has been rewritten several times since our initial import.  We've cherry-picked bug fixes when needed.  We're not interested in sharing the ipc/chromium code as written (for a variety of reasons), so it wouldn't make sense for us to spend time on it except for security bugs or big perf wins.

Unless you want to morph this bug to something more specific, like pulling a fix for the spurious warning, this bug is a WONTFIX.
(Assignee)

Comment 4

6 years ago
Morphing to a fix for the warning then.
Summary: Upgrade to recent Chromium IPC → Fix ipc_channel_win.cpp WARNING about Connect called twice
(Assignee)

Comment 5

6 years ago
Created attachment 526091 [details] [diff] [review]
Fix ipc_channel_win.cpp WARNING about Connect called twice
Attachment #526091 - Flags: review?(jones.chris.g)
(Assignee)

Comment 6

6 years ago
Created attachment 526131 [details] [diff] [review]
Fix ipc_channel_win.cpp WARNING about Connect called twice

Used "try" as my compiler, and it fails. :/ Is it OK to just remove the darn
warning?
Attachment #526131 - Flags: review?(jones.chris.g)
(Assignee)

Updated

6 years ago
Attachment #526091 - Attachment is obsolete: true
Attachment #526091 - Flags: review?(jones.chris.g)
Comment on attachment 526131 [details] [diff] [review]
Fix ipc_channel_win.cpp WARNING about Connect called twice

Yeah.  Let's just wrap it in #ifndef CHROMIUM_MOZILLA_BUILD.
Attachment #526131 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 8

6 years ago
Pushed http://hg.mozilla.org/mozilla-central/rev/e60b8be7a97b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → ben
You need to log in before you can comment on or make changes to this bug.