Closed
Bug 650083
Opened 14 years ago
Closed 14 years ago
nsEditor.cpp:1147: warning: unused variable 'rv'
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: dholbert, Assigned: ehsan.akhgari)
References
()
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
1.03 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Filing bug on these warnings:
> editor/libeditor/base/nsEditor.cpp: In member function 'virtual nsresult nsEditor::GetDocumentCharacterSet(nsACString_internal&)':
> editor/libeditor/base/nsEditor.cpp:1147: warning: unused variable 'rv'
> editor/libeditor/base/nsEditor.cpp: In member function 'virtual nsresult nsEditor::SetDocumentCharacterSet(const nsACString_internal&)':
> editor/libeditor/base/nsEditor.cpp:1158: warning: unused variable 'rv'
Looks like these have been unused since their chunks of code were added in this cset for bug 407127, a few weeks back:
http://hg.mozilla.org/mozilla-central/rev/81c3902d4e78
|
Reporter | |
Comment 1•14 years ago
|
||
The code in question is:
1147 nsresult rv = NS_OK;
1148 nsCOMPtr<nsIDocument> doc = do_QueryReferent(mDocWeak);
1149 NS_ENSURE_TRUE(doc, NS_ERROR_UNEXPECTED);
1150
1151 characterSet = doc->GetDocumentCharacterSet();
1152 return NS_OK;
and:
1158 nsresult rv = NS_OK;
1159 nsCOMPtr<nsIDocument> doc = do_QueryReferent(mDocWeak);
1160 NS_ENSURE_TRUE(doc, NS_ERROR_UNEXPECTED);
1161
1162 doc->SetDocumentCharacterSet(characterSet);
1163 return NS_OK;
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/base/nsEditor.cpp#1145
Whiteboard: [build_warning]
|
Assignee | |
Comment 2•14 years ago
|
||
Sorry!
Attachment #526094 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•