650083 - nsEditor.cpp:1147: warning: unused variable 'rv'

Status: RESOLVED FIXED

Description

[Daniel Holbert [:dholbert]]

Filing bug on these  warnings:
> editor/libeditor/base/nsEditor.cpp: In member function 'virtual nsresult nsEditor::GetDocumentCharacterSet(nsACString_internal&)':
> editor/libeditor/base/nsEditor.cpp:1147: warning: unused variable 'rv'
> editor/libeditor/base/nsEditor.cpp: In member function 'virtual nsresult nsEditor::SetDocumentCharacterSet(const nsACString_internal&)':
> editor/libeditor/base/nsEditor.cpp:1158: warning: unused variable 'rv'

Looks like these have been unused since their chunks of code were added in this cset for bug 407127, a few weeks back:
http://hg.mozilla.org/mozilla-central/rev/81c3902d4e78

Comment 1

[Daniel Holbert [:dholbert]]

The code in question is:
1147   nsresult rv = NS_OK;
1148   nsCOMPtr<nsIDocument> doc = do_QueryReferent(mDocWeak);
1149   NS_ENSURE_TRUE(doc, NS_ERROR_UNEXPECTED);
1150 
1151   characterSet = doc->GetDocumentCharacterSet();
1152   return NS_OK;

and:
1158   nsresult rv = NS_OK;
1159   nsCOMPtr<nsIDocument> doc = do_QueryReferent(mDocWeak);
1160   NS_ENSURE_TRUE(doc, NS_ERROR_UNEXPECTED);
1161 
1162   doc->SetDocumentCharacterSet(characterSet);
1163   return NS_OK;

http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/base/nsEditor.cpp#1145

Comment 2

[:Ehsan Akhgari (needinfo please, extremely long backlog)]

Created attachment 526094 [details] [diff] [review]
Patch (v1)

Sorry!

Comment 3

[:Ehsan Akhgari (needinfo please, extremely long backlog)]

http://hg.mozilla.org/mozilla-central/rev/0c1749cfcc38