650116 - [OS/2] build break in nsHttpHandler after checkin for bug526207

Status: RESOLVED INVALID

(Core :: Networking: HTTP, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; Warp 4.5; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: 

In file included from E:/hg-src/hg/comm-central/mozilla/netwerk/protocol/http/nsHttpAuthManager.cpp:
39:
E:/hg-src/hg/comm-central/mozilla/netwerk/protocol/http/nsHttpChannel.h:354: error: field 'mSelfAddr' has incomplete type
E:/hg-src/hg/comm-central/mozilla/netwerk/protocol/http/nsHttpChannel.h:355: error: field 'mPeerAddr' has incomplete type
nsHttpHandler.cpp
g++ -o nsHttpHandler.o -c   -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API
 -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DSTATIC_EXPORTABLE_JS_
API -DOSTYPE=\"OS22.45\" -DOSARCH=OS2 -DIMPL_NS_NET -IE:/hg-src/hg/comm-central/mozilla/netwerk/prot
ocol/http/../../base/src -IE:/hg-src/hg/comm-central/mozilla/xpcom/ds -IE:/hg-src/hg/comm-central/mozilla/content/base/src -IE:/hg-src/hg/comm-central/mozilla/content/events/src  -IE:/hg-src/hg/comm-c
entral/mozilla/netwerk/protocol/http -I. -I../../../dist/include -I../../../dist/include/nsprpub  -I
E:/mozbuild1/dist/include/nspr -IE:/mozbuild1/dist/include/nss         -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-
align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -fno-strict-aliasing -Zomf -pipe  -DNDEBUG -DTRIMMED -O2   -DMOZILLA_CLIENT -include ../../../mozilla-conf
ig.h -Uunix -U__unix -U__unix__ -MD -MF .deps/nsHttpHandler.pp E:/hg-src/hg/comm-central/mozilla/netwerk/protocol/http/nsHttpHandler.cpp
make.exe[7]: *** [nsHttpAuthManager.o] Error 1
make.exe[7]: *** Waiting for unfinished jobs....
In file included from E:/hg-src/hg/comm-central/mozilla/netwerk/protocol/http/nsHttpHandler.cpp:51:
E:/hg-src/hg/comm-central/mozilla/netwerk/protocol/http/nsHttpChannel.h:354: error: field 'mSelfAddr' has incomplete type
E:/hg-src/hg/comm-central/mozilla/netwerk/protocol/http/nsHttpChannel.h:355: error: field 'mPeerAddr' has incomplete type
E:/hg-src/hg/comm-central/mozilla/netwerk/protocol/http/nsHttpHandler.cpp: In member function 'void nsHttpHandler::PrefsChanged(nsIPrefBranch*, const char*)':
E:/hg-src/hg/comm-central/mozilla/netwerk/protocol/http/nsHttpHandler.cpp:853: warning: comparison between signed and unsigned integer expressions
make.exe[7]: *** [nsHttpHandler.o] Error 1

Reproducible: Always

Comment 1

[Walter Meinl]

Adding #include prio.h to the include list in netwerk/protocol/http/nsHttpChannel.h unbreaks it.

Comment 2

[Walter Meinl]

Attachment: patch

Comment 3

[Honza Bambas (:mayhemer)]

On my windows build the include chain for nsHttpAuthManager.cpp is:

netwerk\protocol\http\nsHttpHandler.h
netwerk\protocol\http\nsHttp.h
_obj\dist\include\mozilla/net/NeckoChild.h
_obj\ipc\ipdl\_ipdlheaders\mozilla/net/PNeckoChild.h
_obj\ipc\ipdl\_ipdlheaders\mozilla/net/PNecko.h
_obj\dist\include\IPC/IPCMessageUtils.h
_obj\dist\include\nsStringGlue.h
_obj\dist\include\nsString.h
_obj\dist\include\nsSubstring.h
_obj\dist\include\nsAString.h
_obj\dist\include\nsStringFwd.h
_obj\dist\include\nsStringIterator.h
_obj\dist\include\nsCharTraits.h
_obj\dist\include\nsDebug.h
_obj\dist\include\prprf.h
_obj\dist\include\prio.h

These inclusions come before nsHttpChannel.h.  _obj stands for the produced build object directory.

Can you please check where the difference in this include chain on OS/2 case is?

Comment 4

[Walter Meinl]

Comment on attachment 527965 [details] [diff] [review]
patch

Clearing review request since this is caused by the still not working IPC code for OS/2.

Comment 5

[Walter Meinl]

marking invalid as the code will work when IPC works too