650139 - Enable mobile Feedback extension on Aurora channel

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

The Feedback button for desktop is enabled on both Aurora and Beta.  This patch does the same for Fennec.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

oops, wrong patch

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

We need to bump the extension's maxVersion too.

Is there a good way to preprocess this file so that we don't need to do this every six weeks?

Comment 3

[Aakash Desai [:aakashd]]

Build script?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 526134 [details] [diff] [review]
patch v2

We can try preprocessing the install.rdf - but we'd need to do it manually in the Makefile.

I also want to move the feedback add-on to distribution/extensions, like we see in desktop. This will allow us to override the add-on using AMO, if needed.

Those two changes can be a followup

Comment 5

[Aakash Desai [:aakashd]]

Another other thing to mention here is that we're planning on making the feedback button on Desktop standalone and augmenting the Test Pilot UI based on if that button is visible on a toolbar or not. https://bugzilla.mozilla.org/show_bug.cgi?id=649156

Comment 6

[Matt Brubeck (:mbrubeck)]

Comment on attachment 526134 [details] [diff] [review]
patch v2

Requesting approval-mozilla-aurora.  We need to land at least the maxVersion change there if we want feedback in Firefox 5 Beta.

We need both parts of the patch on Aurora if we want to test the feedback extension on Aurora before Firefox 5 reaches Beta.

Comment 7

[Matt Brubeck (:mbrubeck)]

Landed on mozilla-central for Firefox 6:
http://hg.mozilla.org/mozilla-central/rev/fa4889ad04e2

Comment 8

[JP Rosevear [:jpr]]

Comment on attachment 526134 [details] [diff] [review]
patch v2

Only affect mobile dir.

Comment 9

[Matt Brubeck (:mbrubeck)]

Pushed to Aurora (Firefox 5):
http://hg.mozilla.org/mozilla-aurora/rev/d93f57e4a6ca

Comment 10

[Matt Brubeck (:mbrubeck)]

This can't be verified in the current Aurora daily, because the update channel is set to "nightly" instead of "aurora".  Filed bug 650502.

Comment 11

[Kevin Brosnan [Ex-Mozilla]]

Mozilla/5.0 (Android; Linux armv7l; rv:5.0a2) Gecko/20110422 Firefox/5.0a2 Fennec/5.0a2 ID:20110422061830

Comment 12

[Kevin Brosnan [Ex-Mozilla]]

Verified.

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified on Aurora Branch:
Mozilla/5.0 (Android; Linux armv71; rv5.0a2) Gecko/20110509 Firefox/5.0a2 Fennec/5.0a2
Device: Thunderbolt
OS: Android 2.2