Last Comment Bug 650163 - JM+TI: rejoin into the interpreter
: JM+TI: rejoin into the interpreter
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86 Mac OS X
-- normal with 1 vote (vote)
: ---
Assigned To: Brian Hackett (:bhackett)
: Jason Orendorff [:jorendorff]
Depends on: 655938 655940
Blocks: TypeInference
  Show dependency treegraph
Reported: 2011-04-14 17:03 PDT by Brian Hackett (:bhackett)
Modified: 2011-05-09 21:51 PDT (History)
9 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

WIP 1 (427.66 KB, patch)
2011-05-07 05:55 PDT, Brian Hackett (:bhackett)
no flags Details | Diff | Splinter Review
patch (530.88 KB, patch)
2011-05-09 07:33 PDT, Brian Hackett (:bhackett)
no flags Details | Diff | Splinter Review

Description User image Brian Hackett (:bhackett) 2011-04-14 17:03:19 PDT
Currently if we get a type change in a script while inside a compiled version of it, we have to immediately recompile and do on stack replacement.  This is sub-optimal in a couple ways:

- Makes the compiler vulnerable to recompilation thrashing.  Currently there is a gigantic regression on sunspider-crypto-md5 because the core_md5 function starts repeatedly reading holes out of an array at many sites well after it was initially compiled.  Will kludge around this shortly, but it would be better to just rejoin into the interpreter and let it find all the holes.

- Bad/no story for handling OOM in inference.  If we run out of memory during inference then all its information is invalidated, and we basically need to disable inference and recompile the entire compartment.  This is of course problematic if we just had an OOM.  Instead, we could rejoin all JIT frames to the interpreter, throw away all compiled code, and then compile things later on as necessary.

Instead, we could use a trampoline that reads data off the VMFrame and calls Interpret.  The main complexity here is in dealing with rejoins into the middle of an opcode, e.g. INCGNAME and friends.
Comment 1 User image David Anderson [:dvander] 2011-04-14 17:04:07 PDT
Sounds like a reason to get rid of those opcodes!
Comment 2 User image Brian Hackett (:bhackett) 2011-05-07 05:55:44 PDT
Created attachment 530829 [details] [diff] [review]

WIP patch which removes on-stack recompilation, adds an interpreter trampoline (the Interpoline!) and makes all type-manipulating inference calls infallible (most of the diff).  Still missing are handlers for most of the exotic states the stack can be in after making a stub call.
Comment 3 User image Brian Hackett (:bhackett) 2011-05-09 07:33:17 PDT
Created attachment 531041 [details] [diff] [review]

JM patch.  This only updates the trampolines for Mac/Linux x86/x64 and Windows x86, can take a guess at other platforms later but at least Win64 seems to use a different ABI and it's better to have machines to test these trampolines on.
Comment 4 User image Brian Hackett (:bhackett) 2011-05-09 15:19:08 PDT
Reset the use count for scripts after discarding JIT code (except when recompiling in order to inline calls), so that the script can warm back up some before recompiling.  This combines script->callCount and compartment->backEdgeTable into a single script->useCount, as there is no simple way to clear a script's entries in the back edge table (entries in this table stick around even after the script itself has been destroyed).

Note You need to log in before you can comment on or make changes to this bug.