Closed Bug 650209 Opened 14 years ago Closed 14 years ago

Allow DOMDesktopNotification to use a custom icon in the expanded android notification

Categories

(Core Graveyard :: Widget: Android, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dougt, Assigned: alexp)

Details

Attachments

(2 files)

Desktop notifications allows you to specify an icon to be used for display. Currently, we use the Fennec/Firefox icon in the expanded notification view. This really should be the icon that the desktop notification provides.
Attached patch patch v.1Splinter Review
work in progress from blassey. I think it is pretty close, but the layout isn't just right -- I think we want to get some space around the image... Madhava should also chime in. Alex, what do you think about this patch? Could you take a screenshot and talk to Madhava about what we want here?
Assignee: nobody → doug.turner
Attachment #526195 - Flags: feedback?(alexp)
Attached image Screenshot
How about this? Madhava?
Assignee: doug.turner → alexp
I approve of the icon used. it is pure awesomeness.
Comment on attachment 526195 [details] [diff] [review] patch v.1 r+
Attachment #526195 - Flags: feedback?(alexp) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: