Closed Bug 650209 Opened 13 years ago Closed 13 years ago

Allow DOMDesktopNotification to use a custom icon in the expanded android notification

Categories

(Core Graveyard :: Widget: Android, defect)

Product:
Core Graveyard
Component:
Widget: Android
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dougt, Assigned: alexp)

Details

Attachments

(2 files)

patch v.1
9.41 KB, patch
dougt
: review+
Details | Diff | Splinter Review
Screenshot
34.47 KB, image/png
Details 
Desktop notifications allows you to specify an icon to be used for display.  Currently, we use the Fennec/Firefox icon in the expanded notification view.  This really should be the icon that the desktop notification provides.
Attached patch patch v.1 — — Splinter Review 
work in progress from blassey.

I think it is pretty close, but the layout isn't just right -- I think we want to get some space around the image... Madhava should also chime in.

Alex, what do you think about this patch?  Could you take a screenshot and talk to Madhava about what we want here?
Assignee: nobody → doug.turner
Attachment #526195 - Flags: feedback?(alexp)
Attached image Screenshot — 
How about this?
Madhava?
Assignee: doug.turner → alexp
I approve of the icon used.  it is pure awesomeness.
Comment on attachment 526195 [details] [diff] [review]
patch v.1

r+
Attachment #526195 - Flags: feedback?(alexp) → review+
pushed http://hg.mozilla.org/mozilla-central/rev/f8e4bab69795
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.