The default bug view has changed. See this FAQ.

Allow DOMDesktopNotification to use a custom icon in the expanded android notification

RESOLVED FIXED

Status

()

Core
Widget: Android
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dougt, Assigned: alexp)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Desktop notifications allows you to specify an icon to be used for display.  Currently, we use the Fennec/Firefox icon in the expanded notification view.  This really should be the icon that the desktop notification provides.
(Reporter)

Comment 1

6 years ago
Created attachment 526195 [details] [diff] [review]
patch v.1

work in progress from blassey.

I think it is pretty close, but the layout isn't just right -- I think we want to get some space around the image... Madhava should also chime in.

Alex, what do you think about this patch?  Could you take a screenshot and talk to Madhava about what we want here?
Assignee: nobody → doug.turner
Attachment #526195 - Flags: feedback?(alexp)
(Assignee)

Comment 2

6 years ago
Created attachment 526321 [details]
Screenshot

How about this?
Madhava?
Assignee: doug.turner → alexp
(Reporter)

Comment 3

6 years ago
I approve of the icon used.  it is pure awesomeness.
(Reporter)

Comment 4

6 years ago
Comment on attachment 526195 [details] [diff] [review]
patch v.1

r+
Attachment #526195 - Flags: feedback?(alexp) → review+
pushed http://hg.mozilla.org/mozilla-central/rev/f8e4bab69795
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.