Last Comment Bug 650209 - Allow DOMDesktopNotification to use a custom icon in the expanded android notification
: Allow DOMDesktopNotification to use a custom icon in the expanded android not...
Product: Core
Classification: Components
Component: Widget: Android (show other bugs)
: unspecified
: x86 Mac OS X
-- normal (vote)
: ---
Assigned To: Alex Pakhotin (:alexp)
: Jim Chen [:jchen] [:darchons]
Depends on:
  Show dependency treegraph
Reported: 2011-04-14 23:49 PDT by Doug Turner (:dougt)
Modified: 2011-04-28 12:36 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch v.1 (9.41 KB, patch)
2011-04-14 23:51 PDT, Doug Turner (:dougt)
doug.turner: review+
Details | Diff | Splinter Review
Screenshot (34.47 KB, image/png)
2011-04-15 11:31 PDT, Alex Pakhotin (:alexp)
no flags Details

Description User image Doug Turner (:dougt) 2011-04-14 23:49:52 PDT
Desktop notifications allows you to specify an icon to be used for display.  Currently, we use the Fennec/Firefox icon in the expanded notification view.  This really should be the icon that the desktop notification provides.
Comment 1 User image Doug Turner (:dougt) 2011-04-14 23:51:42 PDT
Created attachment 526195 [details] [diff] [review]
patch v.1

work in progress from blassey.

I think it is pretty close, but the layout isn't just right -- I think we want to get some space around the image... Madhava should also chime in.

Alex, what do you think about this patch?  Could you take a screenshot and talk to Madhava about what we want here?
Comment 2 User image Alex Pakhotin (:alexp) 2011-04-15 11:31:31 PDT
Created attachment 526321 [details]

How about this?
Comment 3 User image Doug Turner (:dougt) 2011-04-15 11:35:11 PDT
I approve of the icon used.  it is pure awesomeness.
Comment 4 User image Doug Turner (:dougt) 2011-04-27 10:27:05 PDT
Comment on attachment 526195 [details] [diff] [review]
patch v.1

Comment 5 User image Brad Lassey [:blassey] (use needinfo?) 2011-04-28 12:36:32 PDT

Note You need to log in before you can comment on or make changes to this bug.