Lag when redrawing text whose opacity is changed when also animating height

VERIFIED FIXED in Firefox 5

Status

()

Core
Layout
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: wheresrhys, Assigned: roc)

Tracking

({regression})

Trunk
mozilla6
regression
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox5- fixed)

Details

(Whiteboard: [regression from retained layers], URL)

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0

When changing opacity and animating height at the same time position of text is only adjusted at the end of teh animation.

(Sort of duplicates this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=616914)

Reproducible: Always

Steps to Reproduce:
1. Go to http://jsfiddle.net/Mh29G/3/
2. click on the top item in the accordion
3. observe teh misdrawing of text in the bottom two items
Actual Results:  
Text stays in exact same position, gets hidden by the moving containers, and then is redrawn in the correct position at the end of the animation

Expected Results:  
Text moves down with its containing block

Comment 1

6 years ago
Confirmed on
http://hg.mozilla.org/mozilla-central/rev/aa200a803e07
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0a1) Gecko/20110414 Firefox/6.0a1 ID:20110414030535

*It happens regardless of hardware acceleration.
*And also happens Firefox4.0 and Aurora5.0a2.
*Not happens of Firefox3.6.16.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 2

6 years ago
Regression window(cached m-c hourly):
Works:
http://hg.mozilla.org/mozilla-central/rev/92339b84d089
Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; en-US; rv:2.0b2pre) Gecko/20100715 Minefield/4.0b2pre ID:20100715145415
Fails:
http://hg.mozilla.org/mozilla-central/rev/e1d7fd5255fd
Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; en-US; rv:2.0b2pre) Gecko/20100715 Minefield/4.0b2pre ID:20100715152722
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=92339b84d089&tochange=e1d7fd5255fd
Blocks: 564991
Component: General → Layout
Keywords: regression
Product: Firefox → Core
QA Contact: general → layout
Whiteboard: [regression from retained layers]
I see this on Linux as well.  Seems pretty bad for a layers bug.
OS: Windows 7 → All
Hardware: x86 → All
Version: unspecified → Trunk
tracking-firefox5: --- → ?
This is a subtle one. Saving the "Result" frame to a file doesn't show the bug, nor does saving the entire jsfiddle page :-(
Also, doing the test more than once doesn't show the bug. I have to reload the page to get the bug to show again.

Comment 6

6 years ago
(In reply to comment #4)
> This is a subtle one. Saving the "Result" frame to a file doesn't show the bug,
> nor does saving the entire jsfiddle page :-(

Umm, I can reproduce with the following str.
[str]
1 Open the Saved  one("Result" frame).
2 Click 1st row
3 Click 3rd row
4 Click 1st row
Ah, I can reproduce a related bug on a local copy.

Sorry Alice --- I'm not as fast as you :-).
Not tracking for 5, but if there's a safe fix for this in time for beta please nominate the patch.
tracking-firefox5: ? → -
Created attachment 527142 [details]
Reduced testcase
Assignee: nobody → roc
Created attachment 527158 [details] [diff] [review]
fix
Attachment #527158 - Flags: review?(dbaron)
Comment on attachment 527158 [details] [diff] [review]
fix

r=dbaron
Attachment #527158 - Flags: review?(dbaron) → review+
(Did you check that the reftest fails without the patch?)
Whiteboard: [regression from retained layers] → [regression from retained layers][needs landing]
Yes.
Pushed:
http://hg.mozilla.org/mozilla-central/rev/6bd8239e3434
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [regression from retained layers][needs landing] → [regression from retained layers]
Target Milestone: --- → mozilla6
Comment on attachment 527158 [details] [diff] [review]
fix

This is a fairly bad regression in Firefox 4. The patch is very safe, it just causes more invalidation.
Attachment #527158 - Flags: approval-mozilla-aurora?

Updated

6 years ago
Attachment #527158 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [regression from retained layers] → [regression from retained layers][needs landing]
http://hg.mozilla.org/releases/mozilla-aurora/rev/7d4b05121ada
Whiteboard: [regression from retained layers][needs landing] → [regression from retained layers]
Comment on attachment 527158 [details] [diff] [review]
fix

This is a fairly bad regression in Firefox 4. The patch is very safe, it just causes more invalidation.
Attachment #527158 - Flags: approval-mozilla-beta?
Comment on attachment 527158 [details] [diff] [review]
fix

Approved for the mozilla-beta repository, a=dveditz for release-drivers
Attachment #527158 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [regression from retained layers] → [regression from retained layers][needs landing]
http://hg.mozilla.org/releases/mozilla-beta/rev/91d9c8c72dd2
status-firefox5: --- → fixed
Whiteboard: [regression from retained layers][needs landing] → [regression from retained layers]
Mozilla/5.0 (Windows NT 6.1; rv:5.0) Gecko/20100101 Firefox/5.0

Verified the issue using the STR from Comment 6 on Win XP, Win 7, Mac OS X 10.6, Ubuntu x86, Ubuntu x86_64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.